Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand build matrix for glibc #96

Open
IngwiePhoenix opened this issue Jan 21, 2025 · 2 comments
Open

Expand build matrix for glibc #96

IngwiePhoenix opened this issue Jan 21, 2025 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@IngwiePhoenix
Copy link

Is your feature request related to a problem? Please describe.
I am currently building a DevContainers environment for my work place and I noticed that SurrealDB's public releases are glibc only - whilst here, we have musl. On arm64 targets, I like to use musl, since on those boards I usually run Alpine. But here, in a DevContainer, I am on a x86 maschine - so, I can use full fat Debian (well, debian:bookworm-slim, to be precise).

I am not a Github Workflows expert, but I spotted this:
https://github.com/Odonno/surrealdb-migrations/blob/main/.github/workflows/release.yml#L17-L18

What if you were to add x86_64-unknown-linux-gnu?

Describe the solution you'd like
A small update to the release workflow to also include x86_64-unknown-linux-gnu as a target - so that one can grab binaries from the official SurrealDB repository and this repository without needing to wait for a Rust compile to finish.

Describe alternatives you've considered
None that come to mind, really.

Additional context
Got none :) Except to tag my work profile @senpro-ingwersenk for better tracking...

@Odonno Odonno added enhancement New feature or request help wanted Extra attention is needed labels Feb 2, 2025
@Odonno
Copy link
Owner

Odonno commented Feb 2, 2025

Unfortunately, x86_64-unknown-linux-gnu is not a valid/current target when using the rust-build/rust-build.action GitHub action.

I will try to switch to an alternate GitHub action that support more targets.

@IngwiePhoenix
Copy link
Author

Huh, it really isn't o.o https://github.com/rust-build/rust-build.action?tab=readme-ov-file#supported-targets

That's quite a surprise. I'll dig around too, maybe I find something. If I am not wrong, I can test an actuion using the act tool. Should I find something I'll let you know :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants