Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of other keyring #11

Merged
merged 2 commits into from
Nov 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ jobs:
matrix:
include:
- distro: debian10
ansible-version: '>=9, <10'
- distro: debian11
- distro: debian12
- distro: ubuntu1804
Expand Down
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ Set up [VirtualBox](https://www.virtualbox.org/) in Debian-like systems.

* `software-properties-common` (will be installed)
* `dirmngr` (will be installed)
* `apt-transport-https` (will be installed)
* `wget` (will be installed)

#### Variables

Expand Down
30 changes: 19 additions & 11 deletions tasks/repository.yml
Original file line number Diff line number Diff line change
@@ -1,28 +1,36 @@
# tasks file
---
- name: repository | install | dependencies (pre) # noqa args[module]
- name: repository | install dependencies (pre)

Check warning on line 3 in tasks/repository.yml

View workflow job for this annotation

GitHub Actions / Lint

name[casing]

All names should start with an uppercase letter.
ansible.builtin.apt:
name: "{{ virtualbox_dependencies_pre }}"
state: "{{ apt_install_state | default('latest') }}"
update_cache: true
cache_valid_time: "{{ apt_update_cache_valid_time | default(3600) }}"
tags:
- virtualbox-repository-install
- virtualbox-repository-install-dependencies

- name: repository | add public key
ansible.builtin.apt_key:
id: "{{ item.id }}"
url: "{{ item.url }}"
state: present
with_items: "{{ virtualbox_public_keys }}"
- name: repository | (keyrings) directory | create
ansible.builtin.file:
path: "{{ virtualbox_keyring_dst | dirname }}"
state: directory
owner: root
group: root
mode: 0755
tags:
- virtualbox-repository-public-key
- virtualbox-repository-keyrings-directory-create

- name: repository | add repository
- name: repository | (keyring) file | download # noqa command-instead-of-module risky-shell-pipe
ansible.builtin.shell: >
wget -O- {{ virtualbox_keyring_src }} | gpg --dearmor --yes --output {{ virtualbox_keyring_dst }}
args:
creates: "{{ virtualbox_keyring_dst }}"
tags:
- virtualbox-repository-keyring-file-download

- name: repository | add

Check warning on line 30 in tasks/repository.yml

View workflow job for this annotation

GitHub Actions / Lint

name[casing]

All names should start with an uppercase letter.
ansible.builtin.apt_repository:
repo: "{{ item.type }} {{ item.url }} {{ item.component }}"
state: present
state: "{{ item.state | default('present') }}"
update_cache: true
mode: 0644
with_items: "{{ virtualbox_repositories }}"
Expand Down
19 changes: 13 additions & 6 deletions vars/main.yml
Original file line number Diff line number Diff line change
@@ -1,19 +1,26 @@
# vars file
---
virtualbox_keyring_src: https://www.virtualbox.org/download/oracle_vbox_2016.asc
virtualbox_keyring_dst: /usr/share/keyrings/oracle-virtualbox-2016.gpg
virtualbox_repositories:
- type: 'deb [arch=amd64 signed-by={{ virtualbox_keyring_dst }}]'
url: "https://download.virtualbox.org/virtualbox/debian {{ ansible_distribution_release }}"
component: contrib
- type: 'deb [arch=amd64]'
url: "https://download.virtualbox.org/virtualbox/debian {{ ansible_distribution_release }}"
component: contrib
state: absent
- type: 'deb [arch=amd64]'
url: "http://download.virtualbox.org/virtualbox/debian {{ ansible_distribution_release }}"
component: contrib
virtualbox_public_keys:
- id: 54422A4B98AB5139
url: https://www.virtualbox.org/download/oracle_vbox.asc
- id: A2F683C52980AECF
url: https://www.virtualbox.org/download/oracle_vbox_2016.asc
state: absent

virtualbox_dependencies_pre:
- software-properties-common
- dirmngr
- gpg-agent
- apt-transport-https
- wget
- coreutils

virtualbox_dependencies:
- "virtualbox-{{ virtualbox_version }}"
Loading