feat: support for non-18 decimals chains #1997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e into e2e-custom-fee-token
…e into non18-dec-e2e
spsjvc
reviewed
Nov 6, 2024
| import { useNetworks } from './useNetworks' | ||
| import { useNetworksRelationship } from './useNetworksRelationship' | ||
|
|
||
| export const useNativeCurrencyDecimalsOnSourceChain = () => { |
There was a problem hiding this comment.
I feel like this would be a bit nicer
Suggested change
| export const useNativeCurrencyDecimalsOnSourceChain = () => { | |
| export const useSourceChainNativeCurrencyDecimals = () => { |
spsjvc
reviewed
Nov 6, 2024
| @@ -183,6 +183,28 @@ export const startWebApp = (url = '/', qs: { [s: string]: string } = {}) => { | |||
| }) | |||
| } | |||
|
|
|||
| export async function getNativeTokenDecimals({ | |||
There was a problem hiding this comment.
This is currently inside the test files, would it be useful to move inside the codebase?
spsjvc
reviewed
Nov 6, 2024
| latestNetworks.current.sourceChain.id | ||
| ) | ||
|
|
||
| const scaledAmount = |
There was a problem hiding this comment.
I feel like this would be a bit easier to understand if it was just inlined separately for deposit/withdrawal
…n-bridge into non18-dec-e2e
spsjvc
approved these changes
Nov 6, 2024
fionnachan
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.