-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bot-proactive-messaging-teamsfx does not need an AAD app #1311
Comments
Hi @blackchoey! Thank you for bringing this issue to our attention. We will investigate and if we require further information we will reach out in one business day. Please use this link to escalate if you don't get replies. Best regards, Teams Platform |
@blackchoey - Thanks for reporting your issue. We are not quite clear on your issue, could you please provide more details on your issue? |
@blackchoey - Could you please provide more details on your issue to investigate further? |
@Nivedipa-MSFT The sample does not need this step: https://github.com/OfficeDev/Microsoft-Teams-Samples/blob/main/samples/bot-proactive-messaging-teamsfx/teamsapp.yml#L13-L25. |
@blackchoey - We have informed this to the sample team. PR will be raised to make necessary changes. |
@blackchoey - PR has merged. Could you please check and let us know if you have any query here. |
The https://github.com/OfficeDev/Microsoft-Teams-Samples/tree/main/samples/bot-proactive-messaging-teamsfx sample seems not calling external APIs in the code. So it does not need an AAD app.
Below step in
teamsapp.yml
andteamsapp.local.yml
could be removed to avoid creating an AAD app.https://github.com/OfficeDev/Microsoft-Teams-Samples/blob/main/samples/bot-proactive-messaging-teamsfx/teamsapp.yml#L13-L25
Other AAD app related content like the AAD app manifest also needs to be removed.
The text was updated successfully, but these errors were encountered: