Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search by does not refresh the page number #141

Open
chtidom opened this issue Jun 19, 2023 · 3 comments
Open

Search by does not refresh the page number #141

chtidom opened this issue Jun 19, 2023 · 3 comments

Comments

@chtidom
Copy link

chtidom commented Jun 19, 2023

When you display a list and you use the search field above the table the selection is just done on the page displayed while it should do the search on the whole table
Needs to add the following method in the class vendor/okipa/laravel-table/src/Livewire/Table.php
public function updating($name, $value){
if ($name === "searchBy"){
$this->resetPage();
}
}

@jaymeh
Copy link

jaymeh commented Apr 22, 2024

I think this sounds very similar to an issue I am faced with at the moment. When you browse through the table results and you go to "page 17" for instance then do a filter, you get a page like what I have attached. Clicking on page 1 at the bottom shows results but it isn't a nice user experience.

I tried the code mentioned by @chtidom above and that seems to resolve the issue for me although I'm not sure what kind of side effects this could cause.

CleanShot 2024-04-22 at 15 07 33

@HawtDogFlvrWtr
Copy link

Agreed. I'm seeing the same thing and was just about to post about it :D

@HawtDogFlvrWtr
Copy link

This also happens if you select a page number and then change the number of rows to display to something higher than the page number would display. To fix this you need to update the same file with this

    public function changeNumberOfRowsPerPage(int $numberOfRowsPerPage): void
    {
        $this->numberOfRowsPerPage = $numberOfRowsPerPage;
        $this->resetPage();
    }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants