Skip to content

Commit

Permalink
Merge pull request #41 from Oksydan/unique-module-parameter
Browse files Browse the repository at this point in the history
Unique names for parameters
  • Loading branch information
Oksydan authored Sep 19, 2023
2 parents dfd3237 + ae93ff4 commit 45b1d92
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 10 deletions.
8 changes: 4 additions & 4 deletions config/admin/services.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,12 +53,12 @@ services:
oksydan.is_imageslider.handler.file_uploader:
class: 'Oksydan\IsImageslider\Handler\FileUploader'
arguments:
$targetDirectory: '%images_directory%'
$targetDirectory: '%is_imageslider_images_directory%'

oksydan.is_imageslider.handler.file_eraser:
class: 'Oksydan\IsImageslider\Handler\FileEraser'
arguments:
$targetDirectory: '%images_directory%'
$targetDirectory: '%is_imageslider_images_directory%'


#creation/edition form
Expand All @@ -68,7 +68,7 @@ services:
- '@oksydan.is_imageslider.repository.image_slider'
- '@oksydan.is_imageslider.provider.image_provider'
- '@prestashop.core.admin.lang.repository'
- '%placeholder_img%'
- '%is_imageslider_placeholder_img%'
- '@prestashop.adapter.shop.context'

oksydan.is_imageslider.form.identifiable_object.builder.image_slider_form_builder:
Expand Down Expand Up @@ -188,4 +188,4 @@ services:
class: 'Oksydan\IsImageslider\Provider\ImageProvider'
public: true
arguments:
- '%images_uri%'
- '%is_imageslider_images_uri%'
12 changes: 6 additions & 6 deletions config/common.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
parameters:
images_directory: '%kernel.project_dir%/modules/is_imageslider/img/'
module_uri: !php/const _MODULE_DIR_
images_uri: '%module_uri%is_imageslider/img/'
placeholder_img: '/modules/is_imageslider/views/img/placeholder.jpeg'
is_imageslider_images_directory: '%kernel.project_dir%/modules/is_imageslider/img/'
is_imageslider_module_uri: !php/const _MODULE_DIR_
is_imageslider_images_uri: '%is_imageslider_module_uri%is_imageslider/img/'
is_imageslider_placeholder_img: '/modules/is_imageslider/views/img/placeholder.jpeg'

services:
_defaults:
Expand Down Expand Up @@ -33,8 +33,8 @@ services:
class: Oksydan\IsImageslider\Presenter\ImageSlidePresenter
public: true
arguments:
- '%images_uri%'
- '%images_directory%'
- '%is_imageslider_images_uri%'
- '%is_imageslider_images_directory%'
- "@=service('prestashop.adapter.legacy.context').getContext()"

oksydan.is_imageslider.configuration.slider_configuration:
Expand Down

0 comments on commit 45b1d92

Please sign in to comment.