From ae93ff483dcd8b136a88c45eac71340be9aacfcb Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Igor=20Ste=CC=A8pien=CC=81?= <igor@istepien.dev>
Date: Tue, 19 Sep 2023 23:29:09 +0200
Subject: [PATCH] unique names for parameters

---
 config/admin/services.yml |  8 ++++----
 config/common.yml         | 12 ++++++------
 2 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/config/admin/services.yml b/config/admin/services.yml
index 2c3238b..570ebd7 100644
--- a/config/admin/services.yml
+++ b/config/admin/services.yml
@@ -53,12 +53,12 @@ services:
   oksydan.is_imageslider.handler.file_uploader:
     class: 'Oksydan\IsImageslider\Handler\FileUploader'
     arguments:
-      $targetDirectory: '%images_directory%'
+      $targetDirectory: '%is_imageslider_images_directory%'
 
   oksydan.is_imageslider.handler.file_eraser:
     class: 'Oksydan\IsImageslider\Handler\FileEraser'
     arguments:
-      $targetDirectory: '%images_directory%'
+      $targetDirectory: '%is_imageslider_images_directory%'
 
 
   #creation/edition form
@@ -68,7 +68,7 @@ services:
       - '@oksydan.is_imageslider.repository.image_slider'
       - '@oksydan.is_imageslider.provider.image_provider'
       - '@prestashop.core.admin.lang.repository'
-      - '%placeholder_img%'
+      - '%is_imageslider_placeholder_img%'
       - '@prestashop.adapter.shop.context'
 
   oksydan.is_imageslider.form.identifiable_object.builder.image_slider_form_builder:
@@ -188,4 +188,4 @@ services:
     class: 'Oksydan\IsImageslider\Provider\ImageProvider'
     public: true
     arguments:
-      - '%images_uri%'
+      - '%is_imageslider_images_uri%'
diff --git a/config/common.yml b/config/common.yml
index 37dc1fe..6c1acad 100644
--- a/config/common.yml
+++ b/config/common.yml
@@ -1,8 +1,8 @@
 parameters:
-  images_directory: '%kernel.project_dir%/modules/is_imageslider/img/'
-  module_uri: !php/const _MODULE_DIR_
-  images_uri: '%module_uri%is_imageslider/img/'
-  placeholder_img: '/modules/is_imageslider/views/img/placeholder.jpeg'
+  is_imageslider_images_directory: '%kernel.project_dir%/modules/is_imageslider/img/'
+  is_imageslider_module_uri: !php/const _MODULE_DIR_
+  is_imageslider_images_uri: '%is_imageslider_module_uri%is_imageslider/img/'
+  is_imageslider_placeholder_img: '/modules/is_imageslider/views/img/placeholder.jpeg'
 
 services:
   _defaults:
@@ -33,8 +33,8 @@ services:
     class: Oksydan\IsImageslider\Presenter\ImageSlidePresenter
     public: true
     arguments:
-      - '%images_uri%'
-      - '%images_directory%'
+      - '%is_imageslider_images_uri%'
+      - '%is_imageslider_images_directory%'
       - "@=service('prestashop.adapter.legacy.context').getContext()"
 
   oksydan.is_imageslider.configuration.slider_configuration: