Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor some wording #54

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refactor some wording #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions config/admin/services.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,17 +33,17 @@ services:
arguments:
- '@oksydan.is_imageslider.module'

oksydan.is_imageslider.installer.action_databse_create_table:
class: 'Oksydan\IsImageslider\Installer\ActionDatabaseCrateTable'
parent: 'oksydan.is_imageslider.installer.abstract_action_databse'
oksydan.is_imageslider.installer.action_database_create_table:
class: 'Oksydan\IsImageslider\Installer\ActionDatabaseCreateTable'
parent: 'oksydan.is_imageslider.installer.abstract_action_database'
public: true

oksydan.is_imageslider.installer.action_databse_drop_table:
oksydan.is_imageslider.installer.action_database_drop_table:
class: 'Oksydan\IsImageslider\Installer\ActionDatabaseDropTable'
parent: 'oksydan.is_imageslider.installer.abstract_action_databse'
parent: 'oksydan.is_imageslider.installer.abstract_action_database'
public: true

oksydan.is_imageslider.installer.abstract_action_databse:
oksydan.is_imageslider.installer.abstract_action_database:
class: 'Oksydan\IsImageslider\Installer\ActionDatabaseAbstract'
abstract: true
arguments:
Expand Down
4 changes: 2 additions & 2 deletions src/Controller/IsImagesliderController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
use Oksydan\IsImageslider\Cache\TemplateCache;
use Oksydan\IsImageslider\Entity\ImageSlider;
use Oksydan\IsImageslider\Exceptions\DateRangeNotValidException;
use Oksydan\IsImageslider\Filter\ImageSliderFileters;
use Oksydan\IsImageslider\Filter\ImageSliderFilters;
use Oksydan\IsImageslider\Handler\FileEraser;
use Oksydan\IsImageslider\Translations\TranslationDomains;
use PrestaShop\PrestaShop\Core\Grid\Position\Exception\PositionDataException;
Expand Down Expand Up @@ -41,7 +41,7 @@ public function __construct(FileEraser $fileEraser, $languages, TemplateCache $t
$this->templateCache = $templateCache;
}

public function index(ImageSliderFileters $filters): Response
public function index(ImageSliderFilters $filters): Response
{
$imageSliderGridFactory = $this->get('oksydan.is_imageslider.grid.image_slider_grid_factory');
$imageSliderGrid = $imageSliderGridFactory->getGrid($filters);
Expand Down
2 changes: 1 addition & 1 deletion src/Filter/ImageSliderFileters.php → src/Filter/ImageSliderFilters.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
/**
* Class ProductFilter proves default filters for our products grid
*/
final class ImageSliderFileters extends Filters
final class ImageSliderFilters extends Filters
{
/**
* {@inheritdoc}
Expand Down
6 changes: 3 additions & 3 deletions src/Installer/ActionDatabaseCrateTable.php → src/Installer/ActionDatabaseCreateTable.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

namespace Oksydan\IsImageslider\Installer;

class ActionDatabaseCrateTable extends ActionDatabaseAbstract implements ActionDatabaseInterface
class ActionDatabaseCreateTable extends ActionDatabaseAbstract implements ActionDatabaseInterface
{
public const defaultEngine = 'InnoDb';
public const defaultCharset = 'UTF8';
Expand Down Expand Up @@ -47,9 +47,9 @@ private function buildSingleCreateQuery($tableName, $table): string

$dbQuery .= ')';

$dbQuery .= ' ENGINE = ' . (!empty($table['engine']) ? $table['engine'] : ActionDatabaseCrateTable::defaultEngine);
$dbQuery .= ' ENGINE = ' . (!empty($table['engine']) ? $table['engine'] : ActionDatabaseCreateTable::defaultEngine);

$dbQuery .= ' DEFAULT CHARACTER SET ' . (!empty($table['charset']) ? $table['charset'] : ActionDatabaseCrateTable::defaultCharset);
$dbQuery .= ' DEFAULT CHARACTER SET ' . (!empty($table['charset']) ? $table['charset'] : ActionDatabaseCreateTable::defaultCharset);

return $dbQuery;
}
Expand Down
4 changes: 2 additions & 2 deletions src/Installer/ImageSliderInstaller.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ public function createTables(): bool
$container = $this->getContainer();

// THIS WAY INSTEAD OF SERVICE CALL COZ OF NOT AVAILABLE SERVICE DURING INSTALLATION
$createTableAction = new ActionDatabaseCrateTable(
$createTableAction = new ActionDatabaseCreateTable(
$container->get('doctrine.dbal.default_connection'),
$container->getParameter('database_prefix')
);
Expand Down Expand Up @@ -94,7 +94,7 @@ public function dropTables(): bool
{
$databaseData = $this->databaseYaml->getParsedFileData();
$container = $this->getContainer();
$dropTableAction = $container->get('oksydan.is_imageslider.installer.action_databse_drop_table');
$dropTableAction = $container->get('oksydan.is_imageslider.installer.action_database_drop_table');
$dropTableAction
->setData($databaseData)
->buildQuery();
Expand Down