Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow shrubs & trees' model structure to be accessible in the patterns #2

Open
OmarShehata opened this issue Dec 27, 2021 · 0 comments
Labels
good first issue Good for newcomers

Comments

@OmarShehata
Copy link
Owner

In the original entwined you can access cubes just as a global list, or you can target specific pieces of structures, such as individual branches for trees, or individual rods for shrubs.

Right now this isn't possible just because the code doesn't store which cubes are in which structure.

I made a change in this commit 6b93fc5 to fix this for fairy circles. This:

  1. Updates the fairy circle model to store a list of cubes in the mini cluster, and store a list of mini clusters in the overall model
  2. Updates Model.js to store a list of fairyCircles, in addition to storing all of its cubes
  3. Updates PatternBase.js so that all patterns can access a reference to the model

To make this work for trees/shrubs you would need to do steps 1 & 2 for them.

@OmarShehata OmarShehata added the good first issue Good for newcomers label Dec 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant