Fix: add Amazon IAP v3.0.5 handle

[jetie000]

Description

Added Amazon IAP v3.0.5 handle

Details

I'm developing app for business and faced this error while integrating
[email protected]
Error appeared because I also use @revenuecat/[email protected] (versions between 8.0.0 and 9.2.1 use Amazon IAP v3.0.5)
So Amazon IAP v3.0.5 is downloaded and we can't access method at class com.amazon.device.iap.internal.d
line:

OneSignal-Android-SDK/OneSignalSDK/onesignal/core/src/main/java/com/onesignal/core/internal/purchases/impl/TrackAmazonPurchase.kt

Line 83 in c96e91f

listenerHandlerObject = listenerHandlerClass.getMethod("g").invoke(null)

Error screenshot:

This method at v3.0.4

This method at v3.0.5

Manual testing

Steps:

• Create an Ionic Capacitor 6 App
  docs: https://capacitorjs.com/docs/v6/getting-started/with-ionic
• Install and initialize @revenuecat/[email protected] and [email protected]
  docs:
  https://documentation.onesignal.com/docs/ionic-capacitor-cordova-sdk-setup
  https://www.revenuecat.com/docs/getting-started/installation/capacitor
• Run application

Affected code checklist

• Notifications
  • Display
  • Open
  • Push Processing
  • Confirm Deliveries
• Outcomes
• Sessions
• In-App Messaging
• REST API requests
• Public API changes

Checklist

Overview

• I have filled out all REQUIRED sections above
• PR does one thing
  • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
• Any Public API changes are explained in the PR details and conform to existing APIs

Testing

• I have included test coverage for these changes, or explained why they are not needed
• All automated tests pass, or I explained why that is not possible
• I have personally tested this on my device, or explained why that is not possible

Final pass

• Code is as readable as possible.
  • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
• I have reviewed this PR myself, ensuring it meets each checklist item
  • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

---

This change is 

[jetie000]

@nan-li @jkasten2 Can you please have a look?

[nan-li]

Thanks for submitting this PR, please see my comments and we can get this change in!

[nan-li]

From the error log you provided and my own testing, this should catch a NoSuchMethodException.

I don't have clear insight into the Amazon IAP source code, but it seems that calling listenerHandlerObject = listenerHandlerClass.getMethod("e").invoke(null) throws a NPE but calling listenerHandlerObject = listenerHandlerClass.getMethod("g").invoke(null) throws a NoSuchMethodException.

Since we are also nesting try-catches here, even though it is not currently used, let's rename the inner err variable to differ from the outer err variable.

[jetie000]

Thanks for review, I don't have experience with kotlin or java, noticed error in logcat while integrating capacitor library
Changed error variable names and exception class in the catch block

[nan-li]

Great! Thanks!
Noting that g() returns a NoSuchMethodException instead of NPE is because in Amazon IAP 3.0.5, g() is an inaccessible private method. In contrast, there are public methods called d(), e(), f().

[nan-li]

Tested and confirmed on my end with Amazon IAP 3.0.5.