Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Looking for Feedback] OneSignal SDK 5.0.0-beta-01 Released! #868

Closed
jennantilla opened this issue Feb 18, 2023 · 3 comments
Closed

[Looking for Feedback] OneSignal SDK 5.0.0-beta-01 Released! #868

jennantilla opened this issue Feb 18, 2023 · 3 comments

Comments

@jennantilla
Copy link
Contributor

jennantilla commented Feb 18, 2023

In this major version beta release for the OneSignal SDK, we are making a significant shift from a device-centered model to a user-centered model. A user-centered model allows for more powerful omni-channel integrations within the OneSignal platform.

For more information please see the migration guide.

🚧 Beta release. It is not recommended to use in production. 🚧

Please post any feedback related to the beta here!

@jennantilla jennantilla pinned this issue Feb 18, 2023
@nunoarruda
Copy link
Contributor

nunoarruda commented Feb 21, 2023

How about a dedicated OneSignal plugin for Capacitor?

Yes, this OneSignal Cordova plugin mostly works on Capacitor-based projects but there has been some friction.

Plus, it looks like that Capacitor installs/usage already surpasses Cordova. So it might be a good time for OneSignal to have a dedicated Capacitor plugin.

You folks can find more info on creating Capacitor plugins here 👉 https://capacitorjs.com/docs/plugins/tutorial/introduction

Cheers 👍

@jennantilla
Copy link
Contributor Author

Hi @nunoarruda, a dedicated Capacitor plugin is on our radar and something we're hoping to explore further within the next few quarters. Please feel free to leave any additional feedback and we'll be sure to consider it!

@selcuk-sahin
Copy link

Thanks for this version!

The logout functionality in this version should be really useful for us.

I'm using Ionic Capacitor, but I can't seem to work with the request OneSignal.Notifications.canRequestPermission
according to the migration guide usage is this, but the types suggest using a handler here. Also, neither of the solutions did return a result.

let canRequest = window.plugins.OneSignal.Notifications.canRequestPermission(); Whether attempting to request notification permission will show a prompt. Returns true if the device has not been prompted for push notification permission already.

What I tried:

    let canRequest = OneSignal.Notifications.canRequestPermission();
    console.log(canRequest); // undefined
    OneSignal.Notifications.canRequestPermission((canRequestPerm) => {
      console.log(canRequestPerm) // never logged
    })

@jkasten2 jkasten2 unpinned this issue Apr 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants