Fix logout() when push subscription doesn't exists #1194
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One-Line Summary
Fix OneSignal.logout() so it doesn't throw an error if there isn't a push subscription.
Details
A push subscription only exists if the end-user accepted notifications at some point.
OneSignal.logout()
made this bad assumption it always existed.The fix is to check this and create a local only user instead of making a call to OneSignal if there isn't a push subscription.
Validation
Tests
Tested on Chrome Version 128.0.6613.138 on Windows 11 23H2
Scenarios:
Info
Checklist
Programming Checklist
Interfaces:
Functions:
Typescript:
Other:
elem of array
syntax. PreferforEach
or usemap
context
if possible. Instead, we can pass it to function/constructor so that we don't callOneSignal.context
Related Tickets
This change is