[Bug]: Missing support for critical email features

[habovh]

What's on your mind?

[Bug]: Missing support for critical email features

Missing support for the following API parameters:

Generic:

• custom_data

Mail type specific:

• include_unsubscribed
• disable_email_click_tracking

Lack of these features makes this SDK unusable for any kind of transactional email setup containing sensitive data such as password reset tokens. Setting these to the notification object results in the SDK stripping them away and eventually not sending them to the API.

Only solution is to resort to using fetch or similar tools to fetch data and completely lose type safety.

In my opinion this is a high priority issue that should be addressed, but I won't wait for an update nor contribute to the code: if I had the time to do so I would not be looking to use a third-party for my email and notifications needs. I expect paid software SDKs to work, especially for mature companies such as OneSignal. Guess I'm wrong, wasted my time, and I'll be looking elsewhere.

Code of Conduct

• I agree to follow this project's Code of Conduct

[emawby]

@habovh Hello thank you for reaching out we will investigate adding these parameters

[mikeislearning]

I'm having this issue as well, I'm unable to pass dynamic data into the template, which I assume is what the custom_data parameter would be used for. I've also tried the data parameter, but that doesn't work either.

UPDATE: Turns out I had to use {{ message.custom_data.data_field_here }} in my template instead of just using {{ data_field_here }}