Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue resuming and time tracking games with the same name #1703

Open
3 tasks done
jsteel44 opened this issue Nov 15, 2024 · 1 comment
Open
3 tasks done

Issue resuming and time tracking games with the same name #1703

jsteel44 opened this issue Nov 15, 2024 · 1 comment

Comments

@jsteel44
Copy link

Checklist

  • I am reporting a bug in the Onion OS - Any issues with the closed source frontend (MainUI), or RetroArch or any of the cores should be directed to their respective repositories
  • I have reviewed the Onion Docs and did not find the answer
  • I have searched the existing (open and closed) issues to ensure I do not log a duplicate

Onions OS Version

4.3.1-1

Miyoo Firmware Version

202407211632

Provide a clear and concise description of the issue

For example, if a game on the Mega Drive and Game Gear have the same name, eg "Sonic.bin" and "Sonic.gg", both appear in the game switcher as "Sonic". I think this is causing confusion with time tracking and auto-resuming via save states.

Time tracking on these games (with duplicate names) report 0s and never advance.

Save states fail to resume if you switch from one game to the other. I suspect it is trying to resume the save state for the other game and the game freezes/crashes. If you close and load the same game, the save resumes fine, switching between the two does not work.

A solution I have used is to find these duplicates and rename them, then the issue is gone. But I think this should be fixed, for example it could show "Sonic (MD)" and "Sonic (GG)", or show the file extension, and as long as the time tracker and "resuming from save state" know about this, it should avoid the conflict.

Steps to Reproduce

  1. Load two games with the same name (different file extension) (case sensitive) eg Sonic.md and Sonic.gg
  2. With both in the game switcher, try switching between the two and notice the auto save state resume crash the game
  3. Try playing both games and notice that both (or at least one) fails to progress the time displayed in the game switcher (always 0s)

Provide any additional context or information that may help us investigate your issue

Remember the games need to have an identical name (not file extension) to trigger the issues. For example Sonic.md and sonic.gg would not be an issue, only if they share the same name of Sonic.md and Sonic.gg.

@jsteel44
Copy link
Author

jsteel44 commented Nov 16, 2024

I found a bit more information out about these issues.

Regarding the save state issue, the wrong auto save state is being applied between games with the same name (but different file extension). eg switching between these breaks:

  • Sonic (U).md
  • Sonic (U).gg

But this works:

  • Sonic (U).md
  • Sonic (E).gg

This is because the saves are named Saves/CurrentProfile/states/PicoDrive/Saves/CurrentProfile/states/PicoDrive/Sonic (U).state.auto for both .md and .gg versions.

Regarding the time tracking issue not working, this is true if you have two games with exactly the same name, and the file extension must also be the same. In this case one game will track fine, but loading the other file, it remains at 0s. You might ask why you might want to load up the same game from different locations. The answer is if I have a folder "Favourites" for example with a short list of games, but I might also pick it out from the A-Z folder.

Depending on the order of the files (or some reason I do not know) you don't even need to load the second version for the issue to be present, just the presence of the duplicate file can be enough to make the game you are playing remain at 0s.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant