Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with expansion Cargo-Contract-Mod #4

Open
githubgilhad opened this issue Nov 4, 2024 · 0 comments
Open

Problem with expansion Cargo-Contract-Mod #4

githubgilhad opened this issue Nov 4, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@githubgilhad
Copy link

Which expansion is problematic?
Cargo-Contract-Mod v. 1.5
( https://wiki.alioth.net/images/f/f3/Oolite.oxp.Switeck.Cargo-Contract-Mod_1.5.oxz
https://ooliteproject.github.io/oolite-expansion-catalog/expansions/oolite.oxp.Switeck.Cargo-Contract-Mod.html )

Describe the problem
from oolite 1.81 is Cargo-Contract-Mod v. 1.5 obsolete

  • uses structures, which no longer exists - commodity.marketBasePrice, commodity.marketMaskPrice, commodity.marketEcoAdjustPrice
  • so this._priceForCommodity(...) returns 0 everytime (oolite-contracts-cargo.js: 878)
  • so all prices are 0, profit is 0, no contract can be profitable
  • so no contract added to main station

This problem was addressed by its author in version 1.6 and 1.64
see https://bb.oolite.space/viewtopic.php?t=13757

Actual version is 1.64

Cargo Contracts Mod v1.64 -- works with Oolite v1.83 and later!
https://wiki.alioth.net/index.php/File:Oolite.oxp.Switeck.Cargo-Contract-Mod_1.64.oxz
Direct link to the file:
https://wiki.alioth.net/img_auth.php/b/be/Oolite.oxp.Switeck.Cargo-Contract-Mod_1.64.oxz

To Reproduce
Steps to reproduce the behavior:

  1. install oolite 1.90
  2. in Extension Pack Manager add Cargo-Contract-Mod v. 1.5
  3. hyperspace to new system, land on main station, check F4
  4. no Cargo contracts

Expected behavior
Some cargo contracts should be available at least ocassionaly.

Desktop (please complete the following information):

  • OS: [e.g. iOS] Linux 6.1.19-gentoo SMP PREEMPT_DYNAMIC Sun Aug 27 01:29:22 CEST 2023 x86_64 AMD Ryzen 9 3900X 12-Core Processor AuthenticAMD GNU/Linux
  • Oolite version 1.91
  • Oolite Starter version N/A

Sugested Solution
Upgrade to v 1.64 https://wiki.alioth.net/img_auth.php/b/be/Oolite.oxp.Switeck.Cargo-Contract-Mod_1.64.oxz

@githubgilhad githubgilhad added the bug Something isn't working label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant