pyocf: disable test debug logs by default #711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @arutk! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2022-06-02 08:25:05 UTC |
Codecov Report
@@ Coverage Diff @@
## master #711 +/- ##
==========================================
- Coverage 69.04% 69.00% -0.04%
==========================================
Files 90 90
Lines 10066 10105 +39
==========================================
+ Hits 6950 6973 +23
- Misses 3116 3132 +16
|
New commandline switch --debug-log and associated debug_log fixture is added to enable debug logs on demand. Signed-off-by: Adam Rutkowski <[email protected]>
jfckm
previously approved these changes
May 31, 2022
rafalste
previously approved these changes
Jun 2, 2022
kmajzero
approved these changes
Jun 21, 2022
robertbaldyga
requested changes
Aug 6, 2022
Comment on lines
+47
to
+55
| def pytest_addoption(parser): | ||
| parser.addoption("--debug-log", action="store_true", help="enable debug logs") | ||
|
|
||
|
|
||
| @pytest.fixture | ||
| def debug_log(request): | ||
| return request.config.getoption("--debug-log") | ||
|
|
||
|
|
There was a problem hiding this comment.
Pytest already has it's own log level setting. Any chance to use it instead of introducing additional adoption?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New commandline switch --debug-log and associated debug_log fixture
is added to enable debug logs on demand.
Signed-off-by: Adam Rutkowski [email protected]