Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cbuild2cmake] Use ExternalProject_Add_Step for post-build executes #185

Closed
brondani opened this issue Sep 11, 2024 · 0 comments · Fixed by #195
Closed

[cbuild2cmake] Use ExternalProject_Add_Step for post-build executes #185

brondani opened this issue Sep 11, 2024 · 0 comments · Fixed by #195
Assignees
@brondani
Labels
enhancement New feature or request

Comments

@brondani
Copy link
Collaborator

brondani commented Sep 11, 2024 •
edited
Loading

Triggering "post-build" executes described at project level as part of a context build should be possible when generating them in CMakeLists using ExternalProject_Add_Step for the related contexts instead of custom target/command. It should be scheduled for a future release.
See Open-CMSIS-Pack/cbuild#244 (comment)

Addressed in #195, except:

Currently doesn't deal with multiple dependent executes statements though (i.e., an executes-A depends on executes-B depends on context-X currently leads to executes-A not being automatically run). Handling these kinds of transitive reverse-dependencies is difficult.

Verify whether this could be solved by iterating again over the depends-on until no further dependency is found.
@brondani brondani mentioned this issue Sep 11, 2024
Closed
@jkrech jkrech added the enhancement New feature or request label Sep 11, 2024
@jkrech jkrech moved this to Backlog in CMSIS-Toolbox 2.7.0 Sep 17, 2024
EaselinkBachmann added a commit to EaselinkBachmann/cbuild2cmake that referenced this issue Sep 26, 2024
@EaselinkBachmann
[cbuild2cmake] Trigger project executes after project build step
1972748 
This adds a new CONTEXT-executes target to CMake that is automatically
run after build that triggers the executes statements of that project.
Fixes Open-CMSIS-Pack#185.
@EaselinkBachmann EaselinkBachmann mentioned this issue Sep 26, 2024
Merged
EaselinkBachmann added a commit to EaselinkBachmann/cbuild2cmake that referenced this issue Sep 26, 2024
@EaselinkBachmann
[cbuild2cmake] Trigger project executes after project build step
f0ad603 
This adds a new CONTEXT-executes target to CMake that is automatically
run after build that triggers the executes statements of that project.
Fixes Open-CMSIS-Pack#185.
EaselinkBachmann added a commit to EaselinkBachmann/cbuild2cmake that referenced this issue Oct 1, 2024
@EaselinkBachmann
[cbuild2cmake] Trigger project executes after project build step
8424e92 
This adds a new CONTEXT-executes target to CMake that is automatically
run after build that triggers the executes statements of that project.
Fixes Open-CMSIS-Pack#185.
@jkrech jkrech mentioned this issue Oct 1, 2024
Closed
13 tasks
EaselinkBachmann added a commit to EaselinkBachmann/cbuild2cmake that referenced this issue Oct 8, 2024
@EaselinkBachmann
[cbuild2cmake] Trigger project executes after project build step
ded205c 
This adds a new CONTEXT-executes target to CMake that is automatically
run after build that triggers the executes statements of that project.
Fixes Open-CMSIS-Pack#185.
EaselinkBachmann added a commit to EaselinkBachmann/cbuild2cmake that referenced this issue Oct 8, 2024
@EaselinkBachmann
[cbuild2cmake] Trigger project executes after project build step
e8eed57 
This adds a new CONTEXT-executes target to CMake that is automatically
run after build that triggers the executes statements of that project.
Fixes Open-CMSIS-Pack#185.
EaselinkBachmann added a commit to EaselinkBachmann/cbuild2cmake that referenced this issue Oct 16, 2024
@EaselinkBachmann
[cbuild2cmake] Trigger project executes after project build step
0925de3 
This adds a new CONTEXT-executes target to CMake that is automatically
run after build that triggers the executes statements of that project.
Fixes Open-CMSIS-Pack#185.
EaselinkBachmann added a commit to EaselinkBachmann/cbuild2cmake that referenced this issue Oct 22, 2024
@EaselinkBachmann
[cbuild2cmake] Trigger project executes after project build step
2c51a89 
This adds a new CONTEXT-executes target to CMake that is automatically
run after build that triggers the executes statements of that project.
Fixes Open-CMSIS-Pack#185.
@github-project-automation github-project-automation bot moved this from Backlog to Done in CMSIS-Toolbox 2.7.0 Oct 23, 2024
@brondani brondani reopened this Oct 23, 2024
@brondani brondani moved this from Done to In progress in CMSIS-Toolbox 2.7.0 Oct 23, 2024
@brondani brondani mentioned this issue Nov 15, 2024
Merged
@brondani brondani moved this from In progress to In review in CMSIS-Toolbox 2.7.0 Nov 15, 2024
@brondani brondani moved this from In review to Done in CMSIS-Toolbox 2.7.0 Nov 18, 2024
@brondani brondani closed this as completed by moving to Done in CMSIS-Toolbox 2.7.0 Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brondani brondani

Labels
enhancement New feature or request
Projects
No open projects
CMSIS-Toolbox 2.7.0
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[cbuild2cmake] Trigger project executes after project build step EaselinkBachmann/cbuild2cmake
2 participants
@jkrech @brondani