Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split _load_collection depending on FetchType #132

Open
GriffinBabe opened this issue Jun 19, 2024 · 1 comment
Open

Split _load_collection depending on FetchType #132

GriffinBabe opened this issue Jun 19, 2024 · 1 comment

Comments

@GriffinBabe
Copy link
Collaborator

As this function is getting longer (which is why I get the creation of _load_collection_hybrid) we might consider splitting of the pre and post processing of the different fetchtypes. That way it might be easier to find the differences both as a user and future developer.
Not sure if this is in the scope of this PR however, we could create an issue for this.

Originally posted by @VictorVerhaert in #130 (comment)

@GriffinBabe
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant