added costs as a column to tracking databases #664
Conversation
added testing of usage metrics and costs
| @@ -174,6 +174,8 @@ def test_basic(self, tmp_path, job_manager, job_manager_root_dir, sleep_mock): | |||
| ("job-2022", "finished", "foo"), | |||
| ] | |||
|
|
|||
| assert not pd.read_csv(job_db_path)[["cpu", "memory", "duration", "costs"]].isnull().any().any() | |||
There was a problem hiding this comment.
this looks quite cryptic. Can't you assert with real values. All values are predictable, right?
There was a problem hiding this comment.
The values are predictable however also well hidden in the _testing.py file (which isn't in the testing folder but still rests under the src of openeo)
This is why I chose to simply check that the values are not none.
Would it help to add a comment # check that the columns "cpu", "memory", "duration" and "costs" of finished jobs are not empty or do you prefer to check on the actual values and add a comment referencing where they are defined? (last option does hold the danger that when the _testing.py file is moved this comment won't be updated)
Third option of course would be to immediately move the _testing.py file in this PR
#588