connection fixture confusion in processes/processing/conftest.py

[soxofaan]

openeo-test-suite/src/openeo_test_suite/tests/processes/processing/conftest.py

Lines 40 to 45 in 9bab024

	@pytest.fixture(scope="module")
	def connection(
	request, runner: str, auto_authenticate: bool, pytestconfig
	) -> ProcessTestRunner:
	# TODO: this fixture override changes the return type of the original `connection` fixture,
	# which might lead to problems due to broken assumptions

This connection fixture at src/openeo_test_suite/tests/processes/processing/conftest.py
overrides the fixture defined at src/openeo_test_suite/tests/conftest.py:

openeo-test-suite/src/openeo_test_suite/tests/conftest.py

Lines 115 to 116 in 9bab024

	@pytest.fixture(scope="module")
	def connection(request, auto_authenticate: bool, pytestconfig) -> openeo.Connection:

However the return type is changed from openeo.Connection to ProcessTestRunner, which might lead to problems and broken assumptions.

e.g. I think my question/confusion at #27 is caused by this

How to fix this mismatch?

[m-mohr]

I'm not sure, some types of tests need a Connection, but the individual process tests have a "direct connection". It also felt very akward to subclass Connection and then just implement a couple of methods and all others are "useless".