Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openeo-processes-dask 2024.1.1 gives AttributeError: module 'openeo_processes_dask.specs' has no attribute 'apply_kernel' #39

Open
soxofaan opened this issue Jan 25, 2024 · 6 comments

Comments

@soxofaan
Copy link
Member

Just played with dask runner, and one of the current struggles is

    @pytest.fixture(scope="module")
    def connection(
        request, runner: str, auto_authenticate: bool, pytestconfig
    ) -> ProcessTestRunner:
        # TODO: this fixture override changes the return type of the original `connection` fixture,
        #       which might lead to problems due to broken assumptions
    
        if runner == "dask":
>           from openeo_test_suite.lib.process_runner.dask import Dask

src/openeo_test_suite/tests/processes/processing/conftest.py:40: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
src/openeo_test_suite/lib/process_runner/dask.py:48: in <module>
    registry = create_process_registry()
src/openeo_test_suite/lib/process_runner/dask.py:35: in create_process_registry
    specs = {
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

.0 = <list_iterator object at 0x7fce38927ca0>

    specs = {
>       func.__name__: getattr(specs_module, func.__name__)
        for func in processes_from_module
    }
E   AttributeError: module 'openeo_processes_dask.specs' has no attribute 'apply_kernel'

src/openeo_test_suite/lib/process_runner/dask.py:36: AttributeError

apparently downgrading openeo-processes-dask to 23.11.6 instead of 2024.1.1 (currenlty highest) is workaround

@soxofaan
Copy link
Member Author

cc @m-mohr

@soxofaan
Copy link
Member Author

as quickfix I prevented installing 2024.1.1 in b97d890

Better solution might be to skip this apply_kernel in some way. Or maybe something has to be fixed in openeo-processes-dask. Haven't looked much into the details yet

@m-mohr
Copy link
Member

m-mohr commented Jan 25, 2024

Looks like a bug introduced through Open-EO/openeo-processes-dask#186 @GeraldIr

@GeraldIr
Copy link
Member

GeraldIr commented Feb 5, 2024

This issue should have been fixed by the newest openeo-processes-dask version: https://github.com/Open-EO/openeo-processes-dask/releases/tag/2024.1.2

@soxofaan
Copy link
Member Author

soxofaan commented Feb 5, 2024

with 2024.1.2 the "apply_kernel" issue is indeed gone, but I now get the problem with "mask":

e.g.

___________________________________________________________________________ ERROR at setup of test_process[min-example7-file7-L1-False] ___________________________________________________________________________

request = <SubRequest 'connection' for <Function test_process[min-example0-file0-L1-False]>>, runner = 'dask', auto_authenticate = True, pytestconfig = <_pytest.config.Config object at 0x7fd334fb0d10>

    @pytest.fixture(scope="module")
    def connection(
        request, runner: str, auto_authenticate: bool, pytestconfig
    ) -> ProcessTestRunner:
        # TODO: this fixture override changes the return type of the original `connection` fixture,
        #       which might lead to problems due to broken assumptions
    
        if runner == "dask":
>           from openeo_test_suite.lib.process_runner.dask import Dask

src/openeo_test_suite/tests/processes/processing/conftest.py:40: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
src/openeo_test_suite/lib/process_runner/dask.py:48: in <module>
    registry = create_process_registry()
src/openeo_test_suite/lib/process_runner/dask.py:35: in create_process_registry
    specs = {
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

.0 = <list_iterator object at 0x7fd2ebd67e80>

    specs = {
>       func.__name__: getattr(specs_module, func.__name__)
        for func in processes_from_module
    }
E   AttributeError: module 'openeo_processes_dask.specs' has no attribute 'mask'

src/openeo_test_suite/lib/process_runner/dask.py:36: AttributeError

soxofaan added a commit that referenced this issue Feb 5, 2024
@soxofaan
Copy link
Member Author

soxofaan commented Feb 5, 2024

In 505e6d3 I also black-listed 2024.1.2 in pyproject.toml for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants