Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for downloading XLSX and ODS files (update filenames) #67

Closed
lgs85 opened this issue Dec 1, 2022 · 4 comments
Closed

Add support for downloading XLSX and ODS files (update filenames) #67

lgs85 opened this issue Dec 1, 2022 · 4 comments
Labels
quick Issues that shouldn't take long to resolve

Comments

@lgs85
Copy link

lgs85 commented Dec 1, 2022

Following #63, it would also be useful to support XLSX and ODS as download formats for OFDS CoVE
@ghost ghost mentioned this issue Dec 1, 2022
Open
ghost pushed a commit that referenced this issue Dec 2, 2022
@jarofgreen
spreadsheet: Add spreadsheet upload and download option
ee03f50 
#63
#67
#24
ghost pushed a commit that referenced this issue Dec 2, 2022
@jarofgreen
spreadsheet: Add spreadsheet upload and download option
84b319c 
#63
#67
#24
@ghost
Copy link

ghost commented Dec 6, 2022

Ready for testing on live

@duncandewhurst
Copy link
Contributor

duncandewhurst commented Dec 7, 2022 •
edited
Loading

Looks good! I noticed an issue with the ODS file, which I've logged against Flatten Tool:

A couple of minor changes:

  • ODS format
    • Set -o data.ods in Flatten Tool
    • Change the download link label to data.ods (<filesize>), e.g. image
  • XLSX format
    • Set -o data.xlsx in Flatten Tool
    • Change the download link label to data.xlsx (<filesize>), e.g. image

Edit: I've updated the issue title to reflect the outstanding tasks.

@duncandewhurst duncandewhurst changed the title Add support for downloading XLSX and ODS files Add support for downloading XLSX and ODS files (update filenames) Dec 7, 2022
@duncandewhurst duncandewhurst added the quick Issues that shouldn't take long to resolve label Dec 7, 2022
ghost pushed a commit that referenced this issue Dec 16, 2022
@jarofgreen
spreadsheet: Change download file name and copy on page
1fc9c73 
#67
@ghost
Copy link

ghost commented Dec 20, 2022

All ready for testing on live

@duncandewhurst
Copy link
Contributor

Looks good. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
quick Issues that shouldn't take long to resolve
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lgs85 @duncandewhurst