Add patch for libcuda.so and implement fix for Star Citizen #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patches libcuda.so with the approach seen here: jp7677/dxvk-nvapi#174 (comment) This may also be useful for other games that over-allocate memory when enabling DLSS.
…ure patched libcuda for NVIDIA This expands Open-Wine-Components#132 by implementing the patch that was mentioned, and integrates that into the protonfix.
ProjectSynchro
changed the title
R1kaB3rN
reviewed
Sep 21, 2024
R1kaB3rN
reviewed
Sep 21, 2024
R1kaB3rN
requested changes
Sep 21, 2024
Additionally fix some log function calls (e.g. assumed error was there but crit should be used instead.)
|
Should be good to go now, both for use within and outside of the Linux runtime. |
R1kaB3rN
requested changes
Sep 22, 2024
…andle systems where it's not in the standard PATH. Additionally use `subprocess.run` with explicit encoding handling to reliably capture `ldconfig` output, addressing potential encoding issues outside the Steam Runtime.
R1kaB3rN
requested changes
Sep 22, 2024
|
Overall, this looks ok to me. @mactan-sc for testing or someone else as unfortunately I do not have a NVIDIA GPU in my system. |
Closed
…re both `stdout` and `stderr`.
ProjectSynchro
force-pushed
the
libcuda-patch
branch
from
338d9e5 to
17a428e
Compare
R1kaB3rN
approved these changes
Sep 22, 2024
|
FYI: We've put out a request for testing to our community on the Star Citizen LUG discord. We'll report back with the results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a function (patch_libcuda) into util.py which patches libcuda.so with the approach seen here: jp7677/dxvk-nvapi#174 (comment)
This may also be useful for other games that over-allocate memory when enabling DLSS (I know this affects Star Citizen but I don't have NVIDIA so I am not aware of other titles that have this issue.)
Additionally this expands #132 by integrating that into the protonfix.
Please let me know if you'd like any changes. Testers are also welcome, I don't have an NVIDIA GPU to test this fix.. but in theory it should work based on my eyeballing of the code.
This could also be moved into
umu-starcitizen.pybut there may be other affected games this could help with.