Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fix for dirt 3 outside of steam #159

Merged
merged 6 commits into from
Nov 24, 2024

Conversation

polluxau
Copy link
Contributor

@polluxau polluxau commented Nov 14, 2024

Without this library (openal) dirt 3 wont launch on proton 8 or above outside of steam

This is for running the game on its own with no store available

Database pull request
Open-Wine-Components/umu-database#50

@polluxau polluxau changed the title Fix dirt 3 outside of steam Add fix for dirt 3 outside of steam Nov 14, 2024

def main() -> None:
"""Installs OpenAL library, without it the game simply wont launch on proton 8 or above"""
util.protontricks('Openal')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of a file, this should be a symbolic link to the corresponding Steam fix

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be deleted. Remove the file locally then commit and force push your changes.

@R1kaB3rN
Copy link
Member

R1kaB3rN commented Nov 22, 2024

I won't ask how you acquired this game. But this game is broken under Proton and we already had a fix for it, so I'm fine with creating this fix.

@R1kaB3rN R1kaB3rN marked this pull request as ready for review November 22, 2024 21:07
@polluxau
Copy link
Contributor Author

polluxau commented Nov 23, 2024

I won't ask how you acquired this game. But this game is broken under Proton and we already had a fix for it, so I'm fine with creating this fix.

Do you want the symbolic link still?

Question also, if its a symbolic link the file is 321040.py, will it still be detected if its like that on a copy of dirt 3 outside of steam from no store?

Added symbolic link :)

gamefixes-umu/321040.py Outdated Show resolved Hide resolved

def main() -> None:
"""Installs OpenAL library, without it the game simply wont launch on proton 8 or above"""
util.protontricks('Openal')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be deleted. Remove the file locally then commit and force push your changes.

@R1kaB3rN
Copy link
Member

R1kaB3rN commented Nov 23, 2024

Question also, if its a symbolic link the file is 321040.py, will it still be detected if its like that on a copy of dirt 3 outside of steam from no store?

Yes, but detection and usage of the fix depends.

The entire system of applying fixes relies on metadata being available and the user/client giving umu that info. For example, when setting GAMEID=umu-0 and STORE=none or STORE=, by default, the module will search the umu-database.csv for umu-0. On the other hand, for a game with no store, if the client (e.g., Lutris) sets the ID and store, then protonfixes may not apply the fix.

@R1kaB3rN R1kaB3rN merged commit b7c161d into Open-Wine-Components:master Nov 24, 2024
2 checks passed
@polluxau polluxau deleted the dirt3protonfix branch November 24, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants