-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Newer) Many WMP9 Video Playback fixes for Yuzusoft VN's #63
Conversation
Great job. That's much better now, not worth to keep trying. Although it's a shame that i don't have any of those games because i'm curious where the problem is with quartz since it's called by directshow. Maybe calling directshow before wmp9 would work, if not then it's a problem with the order that amstream is called inside directshow. By the way did you figure out the naming of the protonfix for the non steam game and the entry for the database? |
I figured the Non-Steam one out, The title i tried was Sabbat of the Witch directly from the Nekonyan Store (Doing it was a hard process requiring Launch commands and a directory different from the normal GE-Proton one) I am not going to bother with retrying the scripts i submitted because if it already works then there isn't a reason to keep trying. |
Yes, there's no need. I was just curious. It's not like quartz is installed twice, when directshow calls it it's already installed. |
Presumably, you must be creating the files from Github instead from a terminal, correct? Because you didn't have to close the previous pull request. |
|
||
def main(): | ||
""" | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either delete this empty docstring or add a short comment summarizing the fix and its aim. Otherwise, the CI will always fail.
""" | ||
""" | ||
util.protontricks('quartz') | ||
util.protontricks('wmp9') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tested with wmp11
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WMP11 install instead of WMP9 results in a black screen.
This will fix 100% WMP9 Video Playback for many Yuzusoft VN's, Including Riddle Joker. I am very certain this works, excluding even a single command will either cause a black screen, laggy or no audio or it just wont play. (I tested this very well) Reuploaded again to fix a tiny error, Only the Steam editions of these titles were tested and Full audio and video for FMV Scenes work. Other storefronts will most likely work considering there is no difference between versions