Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve street distillation #6

Open
pezholio opened this issue Jan 13, 2015 · 0 comments
Open

Improve street distillation #6

pezholio opened this issue Jan 13, 2015 · 0 comments

Comments

@pezholio
Copy link
Member

At the moment, https://github.com/OpenAddressesUK/distiller/blob/master/lib/distil.rb#L74 is a bit of a mess.

We assume we're always going to have a geometry and match it EXACTLY, which was fine(ish) when we only had one source, but we need to look at this in more detail.

I don't see why we can't do something similar to https://github.com/OpenAddressesUK/distiller/blob/master/lib/distil.rb#L47, which if it finds multiple localities with the same name, finds the nearest locality to that addresses' postcode.

That said, we may have some issues when we start importing addresses without postcodes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant