Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how to test open pull requests #2244

Open
chrisinajar opened this issue Jun 16, 2018 · 4 comments
Open

Document how to test open pull requests #2244

chrisinajar opened this issue Jun 16, 2018 · 4 comments

Comments

@chrisinajar
Copy link
Member

Create documentation in the docs folder containing everything related to getting other people's pull requests onto your local for testing. Additionally, instruct people to use the tACK / utACK paradigm. An ACK is an approval of the pull request, t vs ut implies if they personally tested it or not.

An example of when utACK is useful would be a simple PR that just changes some KV. Testers can review the changes in the source tab and leave utACK (this is something I do occasionally).

A review of a pull request should always result in either tACK, utACK, or changes requested.

@chrisinajar
Copy link
Member Author

the magic git commands are

git remote add username [email protected]:username/oaa.git

once for each new remote, once added you can test any number of PR's from them with

git fetch username
git checkout -b feature_name username/feature_name

@fcalife
Copy link
Contributor

fcalife commented Jun 16, 2018

Minor gripe: some kv's don't work at all - I'd argue unless you're experienced enough to know those, testing is still necessary

@chrisinajar
Copy link
Member Author

a utACK is rarely enough, but is always better than nothing.

@warpdragon
Copy link
Collaborator

hahaha this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants