From 906e82532e665d4d58b0a726ed486eed510bb945 Mon Sep 17 00:00:00 2001
From: Stephanya Casanova <stephanya.casanova@filigran.io>
Date: Tue, 28 Jan 2025 12:59:31 +0100
Subject: [PATCH] [backend/frontend] Clean

---
 .../service/InjectExpectationService.java     | 49 +++++++++----------
 1 file changed, 23 insertions(+), 26 deletions(-)

diff --git a/openbas-api/src/main/java/io/openbas/service/InjectExpectationService.java b/openbas-api/src/main/java/io/openbas/service/InjectExpectationService.java
index 704144a151..bede41a827 100644
--- a/openbas-api/src/main/java/io/openbas/service/InjectExpectationService.java
+++ b/openbas-api/src/main/java/io/openbas/service/InjectExpectationService.java
@@ -230,40 +230,37 @@ public InjectExpectation deleteInjectExpectationResult(
     return updated;
   }
 
-  private void deleteInjectExpectationResultAsset(String sourceId, InjectExpectation updated) {
-    List<InjectExpectation> expectationAssets =
-        this.expectationsForAssets(updated.getInject(), updated.getAssetGroup(), updated.getType());
+  private void deleteInjectExpectationResult(
+      String sourceId, InjectExpectation updated, boolean isAsset) {
+    List<InjectExpectation> expectations =
+        isAsset
+            ? this.expectationsForAssets(
+                updated.getInject(), updated.getAssetGroup(), updated.getType())
+            : this.expectationsForAgents(
+                updated.getInject(), updated.getAsset(), updated.getType());
 
-    expectationAssets.forEach(
-        expectationAsset -> {
-          expectationAsset.setResults(
-              expectationAsset.getResults().stream()
+    expectations.forEach(
+        expectation -> {
+          expectation.setResults(
+              expectation.getResults().stream()
                   .filter(r -> !sourceId.equals(r.getSourceId()))
                   .toList());
-          expectationAsset.setScore(updated.getScore());
-          expectationAsset.setUpdatedAt(updated.getUpdatedAt());
-
-          deleteInjectExpectationResultAgent(sourceId, expectationAsset);
+          expectation.setScore(updated.getScore());
+          expectation.setUpdatedAt(updated.getUpdatedAt());
+          if (isAsset) {
+            deleteInjectExpectationResultAgent(sourceId, expectation);
+          }
         });
 
-    injectExpectationRepository.saveAll(expectationAssets);
+    injectExpectationRepository.saveAll(expectations);
   }
 
-  private void deleteInjectExpectationResultAgent(String sourceId, InjectExpectation updated) {
-    List<InjectExpectation> expectationAgents =
-        this.expectationsForAgents(updated.getInject(), updated.getAsset(), updated.getType());
-
-    expectationAgents.forEach(
-        expectationAgent -> {
-          expectationAgent.setResults(
-              expectationAgent.getResults().stream()
-                  .filter(r -> !sourceId.equals(r.getSourceId()))
-                  .toList());
-          expectationAgent.setScore(updated.getScore());
-          expectationAgent.setUpdatedAt(updated.getUpdatedAt());
-        });
+  private void deleteInjectExpectationResultAsset(String sourceId, InjectExpectation updated) {
+    deleteInjectExpectationResult(sourceId, updated, true);
+  }
 
-    injectExpectationRepository.saveAll(expectationAgents);
+  private void deleteInjectExpectationResultAgent(String sourceId, InjectExpectation updated) {
+    deleteInjectExpectationResult(sourceId, updated, false);
   }
 
   // -- COMMUN --