Skip to content

Commit

Permalink
[backend/frontend] Better code
Browse files Browse the repository at this point in the history
  • Loading branch information
RomuDeuxfois committed Oct 15, 2024
1 parent 4b836c9 commit c523ef7
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ public Page<AssetGroupOutput> assetGroups(@RequestBody @Valid SearchPaginationIn
return this.assetGroupCriteriaBuilderService.assetGroupPagination(searchPaginationInput);

Check warning on line 59 in openbas-api/src/main/java/io/openbas/rest/asset_group/AssetGroupApi.java

View check run for this annotation

Codecov / codecov/patch

openbas-api/src/main/java/io/openbas/rest/asset_group/AssetGroupApi.java#L59

Added line #L59 was not covered by tests
}

@PostMapping("/api/teams/find")
@PostMapping(ASSET_GROUP_URI + "/find")
@PreAuthorize("isObserver()")
@Transactional(readOnly = true)
@Tracing(name = "Find teams", layer = "api", operation = "POST")
Expand Down Expand Up @@ -103,11 +103,3 @@ public void deleteAssetGroup(@PathVariable @NotBlank final String assetGroupId)
}

}

// Before
// Time without filters -> 0.02
// Time with filters -> 0.013

// After
// Time without filters -> 0.02
// Time with filters -> 0.009
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ const AssetGroupDialogAdding: FunctionComponent<Props> = ({
entityPrefix="asset_group"
availableFilterNames={availableFilterNames}
queryableHelpers={queryableHelpers}
/>;
/>;

return (
<Dialog
Expand Down

0 comments on commit c523ef7

Please sign in to comment.