Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In Add users to group, only the first 10 can be viewed or selected #2077

Open
damians-filigran opened this issue Dec 16, 2024 · 3 comments
Open
Assignees
Labels
bug use for describing something not working as expected
Milestone

Comments

@damians-filigran
Copy link

Description

As an admin, I would like to be able to select all of my users in OpenBAS and add them to a default group. However, OpenBAS only shows the first 10 users, and there is no way to scroll or paginate across to any more. I can search or use tags to select others, however.

Environment

  1. OS (where OpenBAS server runs): SaaS
  2. OpenBAS version: e.g. OpenBAS 1.9.1
  3. OpenBAS client: Edge on MacOS
  4. Other environment details: se2.obas

Reproducible Steps

Steps to create the smallest reproducible scenario:

  1. Go to /admin/settings/security/groups
  2. Click a group ... and Manage Users
  3. Start clicking to select

Expected Output

Expect to be able to scroll down to the entire list that match the default (all), or search/tag filter

Actual Output

You can only select the first 10, and cannot scroll/paginate to other

Additional information

Screenshots (optional)

Image
@damians-filigran damians-filigran added bug use for describing something not working as expected needs triage use to identify issue needing triage from Filigran Product team labels Dec 16, 2024
@EllynBsc EllynBsc removed the needs triage use to identify issue needing triage from Filigran Product team label Dec 18, 2024
@EllynBsc EllynBsc added this to the Bugs backlog milestone Dec 18, 2024
@EllynBsc
Copy link
Member

Hi @damians-filigran 👋

Thank you for reporting. @RomuDeuxfois was there any reason why it was made that way ?

@RomuDeuxfois
Copy link
Member

None, it is surely a restriction on the front side that must be lifted.
On the other hand, it is surely present on all popups of this type (adding assets, asset groups, etc.)

My 2 cents on the dev side: we have an atomic component which is not yet used everywhere. It should be improved and used everywhere to align behavior.

@RomuDeuxfois RomuDeuxfois self-assigned this Dec 26, 2024
@RomuDeuxfois
Copy link
Member

In order to fix this issue, pagination was added.
For the pagination to be fully displayed, the drawer must take up the entire page.
I have attached a video, tell me if it suits you @EllynBsc & @jborozco.
https://github.com/user-attachments/assets/e64435f5-ff27-4734-a229-7fc28d867035

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug use for describing something not working as expected
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants