Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What about ff99-disp #346

Open
bcossins opened this issue Sep 29, 2024 · 6 comments
Open

What about ff99-disp #346

bcossins opened this issue Sep 29, 2024 · 6 comments

Comments

@bcossins
Copy link

Only me.

Is your feature request related to a problem? Please describe.
Saw Julien publishing on simulations with a99sb-disp - https://github.com/paulrobustelli/Force-Fields
This ff is not currently in BioSimSpace is it?
I would like to use this.

Describe the solution you'd like
Can we add this ff to the others that are in there?
Is there an easy way for users to add new protein ffs?

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@lohedges
Copy link
Contributor

I think we'd just need a way to make it easier to parameterise with custom force fields. We couldn't support this easily as is since it's just a GitHub repo with the code, not a package that we could add as a requirement. Assuming that the force field doesn't contain any unsupported terms, e.g. CMAP, then it should be easily enough to add something that can find the force field files by name given some path (or if you've added them to AMBER HOME).

@bcossins
Copy link
Author

bcossins commented Sep 29, 2024 via email

@lohedges
Copy link
Contributor

Yeah, it seems self contained. My issue is that it's not versioned so I'm not going to write an API on the basis of something that we can't constrain and might change in future without us realising. I'd rather have a general way for a user to use fully custom AMBER parameters, e.g. by sticking them in a directory then searching for them by the specified forcefield name. It might be tricky if it requires custom waters too, since we don't solvate with AMBER. (They do provide GROMACS files, though.)

@bcossins
Copy link
Author

bcossins commented Sep 29, 2024 via email

@lohedges
Copy link
Contributor

lohedges commented Oct 7, 2024

Just to say that the code has no license, so there's no way that we could vendor it, or easily include as a dependency. I'm sure this isn't an issue in practice, so might be worth asking them to add one. I'll think about a more general interface, though, since I'd rather support any custom force field parameters rather than these specific ones.

@bcossins
Copy link
Author

bcossins commented Oct 7, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants