Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input file information not getting cleared. #12

Open
hsorby opened this issue Feb 12, 2018 · 5 comments
Open

Input file information not getting cleared. #12

hsorby opened this issue Feb 12, 2018 · 5 comments

Comments

@hsorby
Copy link
Collaborator

hsorby commented Feb 12, 2018

The information for input files is not getting cleared after a test specifying at least one input. This can cause an issue for future tests that have optional arguments.

@lorenzo-mechbau
Copy link

Yes, adding a line in a test description like
set(TEST_TARGETS_ARGS "5")
causes the next tests to fail (because the argument is still somehow affecting them).

@hsorby
Copy link
Collaborator Author

hsorby commented Aug 24, 2018

I have a feeling that I have addressed this, I will check what I have done with the changes to fix this problem.

Do you have a the full example test file so I can check what you are running.

@lorenzo-mechbau
Copy link

lorenzo-mechbau commented Sep 26, 2018

Sorry, I missed the reply! But I'm running into the issue today again, so:

Running the examples in the folder attached with the current develop version of iron, as (accordingly modifying the paths):
cmake -DOpenCMISSLibs_DIR=/software/opencmiss/opencmiss/install -DTEST_DB=/Desktop/functional_tests/my_testing_select/ ../functional_test_framework
make

"cantilever" passes, but fails uncommenting
set(TEST_TARGETS_ARGS "2|3|2|1")
in
functional_tests/my_testing_select/laplace_equation.cmake
(Laplace fails anyway)

Thanks!

functional_tests.tar.gz

@lorenzo-mechbau
Copy link

Adding the line below to every test that does not need arguments
set(TEST_TARGETS_ARGS " ")
seems to be a (temporary?) fix.

@lorenzo-mechbau
Copy link

lorenzo-mechbau commented Nov 7, 2018

Actually I run into an error (at laplace_equation) if the line above has a blank space between the quotes (" "):
[ 81%] Completed 'ndiff'
[100%] Built target ndiff
CMake Error at CMakeLists.txt:102 (list):
list index: 1 out of range (-1, 0)

-- Configuring incomplete, errors occurred!
See also "/data/homes/zanon/Desktop/functional_tests/functional_test_framework-build/testsetup-build/CMakeFiles/CMakeOutput.log".
CMakeFiles/setup_tests.dir/build.make:57: recipe for target 'CMakeFiles/setup_tests' failed
make[2]: *** [CMakeFiles/setup_tests] Error 1
CMakeFiles/Makefile2:275: recipe for target 'CMakeFiles/setup_tests.dir/all' failed
make[1]: *** [CMakeFiles/setup_tests.dir/all] Error 2
Makefile:83: recipe for target 'all' failed
make: *** [all] Error 2

Without much investigation, my fix is to use as empty argument line:
set(TEST_TARGETS_ARGS "")
for Fortran and C, and
set(PYTEST_TARGETS_ARGS " ")
for python (with the blank space).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants