Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making command line arguments for our cmake files to be case insensitive #2

Open
PrasadBabarendaGamage opened this issue Nov 6, 2017 · 3 comments

Comments

@PrasadBabarendaGamage
Copy link

Might be best to make the -DOpenCMISSLibs_DIR case insensitive so its easier for users.

@nickerso
Copy link

nickerso commented Nov 6, 2017

Consistent case would be beneficial, but in CMake-land variables are always case-sensitive (pretty sure) and it would be crazy to try and add our own functionality to achieve that. Documentation is more than sufficient to make user's lives easier.

@hsorby
Copy link
Collaborator

hsorby commented Nov 6, 2017

I think also that because every example that creates an executable target needs to have the variable set then every example would also have to have the mechanism for managing the case insensitive variable present. This would then need to apply to any other variables set in the command line and would be going against the nature of the scripting language.

Clear documentation should mitigate this issue.

@chrispbradley
Copy link
Member

The variable is, at the very least, inconsistent with all the other cmake variables used. Most of these OpenCMISS variables are of the form OPENCMISS_XXX. In addition other variables used for identifying locations in file systems are called ROOT e.g., OPENCMISS_ROOT. A more consistent variable name would be OPENCMISS_INSTALL_ROOT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants