-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto save feature #182
Comments
@ghutchis Is this still open? Can I work on this? |
Thanks, yes, it's still open - would certainly love to see some help. Do you need more tips / mentoring? |
Yea, that would be really great. Cloud you tell me where to start ? |
Is this open ? I want to work on this |
@Abhisharma85 yup this is open. You can work on this. |
I wanna work on this issue. Please assign this to me and since I'm new to this repo so I request you to please guide me through. |
hi i would love to work on it kindly assign |
In this project, we do not assign issues except to indicate that a core developer is currently working on something. If you would like to start, please do. There's an example repo linked above. |
@ghutchis where can I find the piece of code that saves the code on clicking save? |
@ShubhamKumar977 - I'm not quite sure what you're asking. Do you want to see the example AutoSave code (see my first comment in the thread) or how Avogadro currently implements a save signal? |
@ghutchis I want to know how Avogadro currently implements a save signal? |
You'll either want: avogadroapp/avogadro/mainwindow.cpp Line 1330 in f1b42f0
Or avogadroapp/avogadro/mainwindow.cpp Line 1460 in f1b42f0
|
I would suggest saving as |
is it still open for me to work on ? |
I still haven't seen a pull request, so yes. |
This issue has been mentioned on Avogadro Discussion. There might be relevant details there: |
The issue seems open. But it's very old, so is it open until now? @ghutchis If yes, i'd like to start working on it. The |
@Atharva-Kanherkar - it's definitely still open. As I mention above, I'm happy to help / mentor. |
Thank you! For starters, ive been understanding the codebase. I will say ill spend one or two days on understanding the code base, and then start working on this. Can you provide me some more information about how i can start, itd be much helpful:) |
Until then, @ghutchis , if there are any documentation and translation tasks (I know hindi pretty well for starters) I can do it while studying the codebase. |
@Atharva-Kanherkar - any work on Hindi would be greatly appreciated: That's all automatically synced - it will show up in avogadroapp and avogadrolibs as pull requests. |
Sure! Ill start working. |
Hi, @ghutchis. I have prepared a google doc to make a roadmap - task bar kind of thing for the future of the implementation. |
Hi, @ghutchis may i start working? |
Sure, of course. A few notes, since I cannot comment on that Google doc:
As you said, we're happy to help with advice and testing - submit a pull request and mark it as "WIP" for work in progress to get code review, run the auto builds, etc. |
Hi, @ghutchis do you have any resources (videos/documentation) to brush up my knowledge of QT? |
https://www.qt.io/academy In reality, I suggest you start by looking at the "SimpleAutosave" example and consider what it does. You can also start by making sure you can build Open Chemistry. |
This issue has been mentioned on Avogadro Discussion. There might be relevant details there: https://discuss.avogadro.cc/t/help-finding-teaching-materials/4993/8 |
@ghutchis is this still open can i work on this? |
There's some work in #490 - but as far as I can tell, it mainly focuses on saving work every 5 minutes. That's great, but the important part of an auto-save is that if the program crashes, when you run again, it offers to open the auto-save files. It also needs some sort of unique identifier if someone has multiple un-saved molecules open. At the moment, it uses the same name. |
Can I still work on this?? @ghutchis |
Avogadro should support an auto-save feature, eg something like https://github.com/faiszalkhan/SimpleAutosave
Save unsaved molecules to the auto save directory every 5 minutes.
The text was updated successfully, but these errors were encountered: