Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto save feature #182

Open
ghutchis opened this issue Jul 28, 2021 · 31 comments · May be fixed by #490
Open

Auto save feature #182

ghutchis opened this issue Jul 28, 2021 · 31 comments · May be fixed by #490
Labels
good first issue hacktoberfest Good first issues for Hacktoberfest help-wanted

Comments

@ghutchis
Copy link
Member

Avogadro should support an auto-save feature, eg something like https://github.com/faiszalkhan/SimpleAutosave

Save unsaved molecules to the auto save directory every 5 minutes.

@ghutchis ghutchis added hacktoberfest Good first issues for Hacktoberfest good first issue labels Sep 28, 2021
@harxish
Copy link

harxish commented Jul 17, 2022

@ghutchis Is this still open? Can I work on this?

@ghutchis
Copy link
Member Author

Thanks, yes, it's still open - would certainly love to see some help. Do you need more tips / mentoring?

@harxish
Copy link

harxish commented Jul 23, 2022

Yea, that would be really great.

Cloud you tell me where to start ?

@Abhisharma85
Copy link

Is this open ? I want to work on this

@harxish
Copy link

harxish commented Jan 4, 2023

@Abhisharma85 yup this is open. You can work on this.

@VARUN-009
Copy link

I wanna work on this issue. Please assign this to me and since I'm new to this repo so I request you to please guide me through.

@Aadijindal07
Copy link

hi i would love to work on it kindly assign

@ghutchis
Copy link
Member Author

ghutchis commented Feb 1, 2023

In this project, we do not assign issues except to indicate that a core developer is currently working on something. If you would like to start, please do. There's an example repo linked above.

@ShubhamKumar977
Copy link

@ghutchis where can I find the piece of code that saves the code on clicking save?

@ghutchis
Copy link
Member Author

@ShubhamKumar977 - I'm not quite sure what you're asking. Do you want to see the example AutoSave code (see my first comment in the thread) or how Avogadro currently implements a save signal?

@ShubhamKumar977
Copy link

@ShubhamKumar977 - I'm not quite sure what you're asking. Do you want to see the example AutoSave code (see my first comment in the thread) or how Avogadro currently implements a save signal?

@ghutchis I want to know how Avogadro currently implements a save signal?

@ghutchis
Copy link
Member Author

You'll either want:

bool MainWindow::saveFile(bool async)

Or

bool MainWindow::saveFileAs(const QString& fileName, Io::FileFormat* writer,

@ghutchis
Copy link
Member Author

I would suggest saving as .cjson, e.g.
writer = new Io::CjsonFormat;

@Aenk-Singhal
Copy link

is it still open for me to work on ?

@ghutchis
Copy link
Member Author

I still haven't seen a pull request, so yes.

@avo-bot
Copy link

avo-bot commented Sep 9, 2023

This issue has been mentioned on Avogadro Discussion. There might be relevant details there:

https://discuss.avogadro.cc/t/how-to-contribute/4569/12

@Atharva-Kanherkar
Copy link

The issue seems open. But it's very old, so is it open until now? @ghutchis If yes, i'd like to start working on it. The
progress would be a little slow as my exams are going on, but will sure move ahead.

@ghutchis
Copy link
Member Author

@Atharva-Kanherkar - it's definitely still open. As I mention above, I'm happy to help / mentor.

@Atharva-Kanherkar
Copy link

@Atharva-Kanherkar - it's definitely still open. As I mention above, I'm happy to help / mentor.

Thank you! For starters, ive been understanding the codebase. I will say ill spend one or two days on understanding the code base, and then start working on this. Can you provide me some more information about how i can start, itd be much helpful:)

@Atharva-Kanherkar
Copy link

Until then, @ghutchis , if there are any documentation and translation tasks (I know hindi pretty well for starters) I can do it while studying the codebase.

@ghutchis
Copy link
Member Author

@Atharva-Kanherkar - any work on Hindi would be greatly appreciated:
https://hosted.weblate.org/engage/avogadro/

That's all automatically synced - it will show up in avogadroapp and avogadrolibs as pull requests.

@Atharva-Kanherkar
Copy link

@Atharva-Kanherkar - any work on Hindi would be greatly appreciated: https://hosted.weblate.org/engage/avogadro/

That's all automatically synced - it will show up in avogadroapp and avogadrolibs as pull requests.

Sure! Ill start working.

@Atharva-Kanherkar
Copy link

Atharva-Kanherkar commented Oct 29, 2023

Hi, @ghutchis. I have prepared a google doc to make a roadmap - task bar kind of thing for the future of the implementation.
Can you please review the doc and tell me if everything's correct so i start working on it? This is just a simple list of tasks id need to do.
Thank you!
Here is the link : https://docs.google.com/document/d/1yA0rhWgOiO00GeKlP8gpGtTGhAV7YYryjLGmjCTkBt8/edit?usp=sharing

@Atharva-Kanherkar
Copy link

Hi, @ghutchis may i start working?

@ghutchis
Copy link
Member Author

ghutchis commented Oct 31, 2023

Sure, of course.

A few notes, since I cannot comment on that Google doc:

As you said, we're happy to help with advice and testing - submit a pull request and mark it as "WIP" for work in progress to get code review, run the auto builds, etc.

@Atharva-Kanherkar
Copy link

Hi, @ghutchis do you have any resources (videos/documentation) to brush up my knowledge of QT?

@ghutchis
Copy link
Member Author

ghutchis commented Nov 1, 2023

https://www.qt.io/academy
https://doc.qt.io/qt-5/classes.html

In reality, I suggest you start by looking at the "SimpleAutosave" example and consider what it does.

You can also start by making sure you can build Open Chemistry.

@avo-bot
Copy link

avo-bot commented Nov 24, 2023

This issue has been mentioned on Avogadro Discussion. There might be relevant details there:

https://discuss.avogadro.cc/t/help-finding-teaching-materials/4993/8

@bhavyaarya7
Copy link

@ghutchis is this still open can i work on this?

@ghutchis
Copy link
Member Author

ghutchis commented Dec 8, 2024

There's some work in #490 - but as far as I can tell, it mainly focuses on saving work every 5 minutes. That's great, but the important part of an auto-save is that if the program crashes, when you run again, it offers to open the auto-save files.

It also needs some sort of unique identifier if someone has multiple un-saved molecules open. At the moment, it uses the same name.

@yuvrajshr
Copy link

Can I still work on this?? @ghutchis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue hacktoberfest Good first issues for Hacktoberfest help-wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.