From 7aa46e3d60d3ea58955601f6979fec8b597361e2 Mon Sep 17 00:00:00 2001
From: Geoff Hutchison <geoff.hutchison@gmail.com>
Date: Tue, 19 Nov 2024 16:51:34 -0500
Subject: [PATCH] Fix Codacy warning about initializer

Signed-off-by: Geoff Hutchison <geoff.hutchison@gmail.com>
---
 avogadro/rendering/arrowgeometry.cpp | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/avogadro/rendering/arrowgeometry.cpp b/avogadro/rendering/arrowgeometry.cpp
index 10f5ba0abf..b1aac510fb 100644
--- a/avogadro/rendering/arrowgeometry.cpp
+++ b/avogadro/rendering/arrowgeometry.cpp
@@ -41,16 +41,16 @@ class ArrowGeometry::Private
   ShaderProgram program;
 };
 
-ArrowGeometry::ArrowGeometry() : m_dirty(false), d(new Private)
+ArrowGeometry::ArrowGeometry()
+  : m_dirty(false), d(new Private), m_color(0, 255, 0)
 {
-  m_color = Vector3ub(0, 255, 0);
 }
 
 ArrowGeometry::ArrowGeometry(const ArrowGeometry& other)
   : Drawable(other), m_vertices(other.m_vertices),
-    m_lineStarts(other.m_lineStarts), m_dirty(true), d(new Private)
+    m_lineStarts(other.m_lineStarts), m_color(other.m_color), m_dirty(true),
+    d(new Private)
 {
-  m_color = other.m_color;
 }
 
 ArrowGeometry::~ArrowGeometry()