Fix a bug with file paths and movies

The canonicalPath method returns an empty string if the file does not exist, causing a number of issues when used in the context of saving a movie. Switch to use absolutePath which does not care whether the file exists or not. Signed-off-by: Marcus D. Hanwell <[email protected]>
OpenChemistry · Aug 21, 2018 · ea895eb · ea895eb
1 parent 06aa7d7
commit ea895eb
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/avogadro/qtplugins/playertool/playertool.cpp b/avogadro/qtplugins/playertool/playertool.cpp
@@ -248,7 +248,7 @@ void PlayerTool::recordMovie()
 
   QFileInfo fileInfo(baseName);
   if (!fileInfo.suffix().isEmpty())
-    baseName = fileInfo.canonicalPath() + "/" + fileInfo.baseName();
+    baseName = fileInfo.absolutePath() + "/" + fileInfo.baseName();
 
   bool bonding = m_dynamicBonding->isChecked();
   int numberLength = static_cast<int>(

diff --git a/avogadro/qtplugins/surfaces/surfaces.cpp b/avogadro/qtplugins/surfaces/surfaces.cpp
@@ -392,7 +392,7 @@ void Surfaces::recordMovie()
 
   QFileInfo fileInfo(baseName);
   if (!fileInfo.suffix().isEmpty())
-    baseName = fileInfo.canonicalPath() + "/" + fileInfo.baseName();
+    baseName = fileInfo.absolutePath() + "/" + fileInfo.baseName();
 
   m_baseFileName = baseName;
   m_numberLength = static_cast<int>(