Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Total Charge / Spin Multiplicity #1059

Closed
2 tasks done
ghutchis opened this issue Jul 27, 2022 · 5 comments · Fixed by #1810
Closed
2 tasks done

Total Charge / Spin Multiplicity #1059

ghutchis opened this issue Jul 27, 2022 · 5 comments · Fixed by #1810

Comments

@ghutchis
Copy link
Member

ghutchis commented Jul 27, 2022

File import / export and input generators need better support for total charge / spin multiplicity.

If I read in a calculation, the program should know throughout that the total charge / spin is set (e.g., H3O+ or OH-, etc.)

PR #1058 gets things started

  • quantumio readers need update
  • input generator scripts should get total charge and spin through JSON
@matterhorn103
Copy link
Contributor

We will also need a way for the user to actually set the total charge/spin for a molecule somewhere in the GUI, outside of an input generator script.

Just mentioning it here so that we don't forget :)

@ghutchis
Copy link
Member Author

@matterhorn103 - coming back to this now - should the new Molecular Properties table always show the total charge and spin to allow them to be edited?

@matterhorn103
Copy link
Contributor

matterhorn103 commented Nov 21, 2024

Yes, definitely. It's hard to change otherwise, and imo it's also just generally confusing if it's sometimes not shown.

@ghutchis
Copy link
Member Author

See #1810 - still need to update the input generators accordingly (sigh)

@ghutchis ghutchis linked a pull request Nov 21, 2024 that will close this issue
@ghutchis
Copy link
Member Author

Actually, that was easier than I thought - the input generators will now auto-update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: To do
Development

Successfully merging a pull request may close this issue.

2 participants