From 63db4d1146172a447058fe9a73481961434e9a95 Mon Sep 17 00:00:00 2001 From: Surajjalpun2002 Date: Sun, 22 Oct 2023 02:23:49 +0530 Subject: [PATCH 1/2] changes regarding use of constexpr in case of constant variables Signed-off-by: Surajjalpun2002 --- avogadro/calc/chargemodel.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/avogadro/calc/chargemodel.cpp b/avogadro/calc/chargemodel.cpp index f3fc749a4c..5fb9ba1187 100644 --- a/avogadro/calc/chargemodel.cpp +++ b/avogadro/calc/chargemodel.cpp @@ -16,7 +16,7 @@ using Core::Molecule; namespace Calc { #ifndef M_PI -#define M_PI 3.14159265358979323846 +constexpr double M_PI = 3.14159265358979323846; #endif ChargeModel::ChargeModel() : m_dielectric(1.0) {} From b2dc900aa7054f5df30af2f29120b6224122e8b9 Mon Sep 17 00:00:00 2001 From: Surajjalpun2002 Date: Sun, 22 Oct 2023 02:28:52 +0530 Subject: [PATCH 2/2] commit cause clang format check failed Signed-off-by: Surajjalpun2002 --- avogadro/calc/chargemodel.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/avogadro/calc/chargemodel.cpp b/avogadro/calc/chargemodel.cpp index 5fb9ba1187..0611a19d75 100644 --- a/avogadro/calc/chargemodel.cpp +++ b/avogadro/calc/chargemodel.cpp @@ -16,7 +16,7 @@ using Core::Molecule; namespace Calc { #ifndef M_PI -constexpr double M_PI = 3.14159265358979323846; +constexpr double M_PI = 3.14159265358979323846; #endif ChargeModel::ChargeModel() : m_dielectric(1.0) {}