Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to SHA256 hashes #138

Open
matterhorn103 opened this issue Oct 29, 2024 · 4 comments · May be fixed by #147
Open

Switch to SHA256 hashes #138

matterhorn103 opened this issue Oct 29, 2024 · 4 comments · May be fixed by #147

Comments

@matterhorn103
Copy link
Contributor

For better security, naturally, but also Flatpak explicitly discourages anything less, and using SHA256 everywhere would then make maintenance easier.

@matterhorn103
Copy link
Contributor Author

Not very urgent though.

@peach280
Copy link

I would love to work on this issue. Can you please elaborate more on it?

@matterhorn103
Copy link
Contributor Author

Currently we use MD5 hashes of assets that are fetched e.g. during the build process, and I think it'd be nice to upgrade them to SHA256.

That would naturally mean not just changing the hashes themselves but also adjusting the things that check the hashes. Most (all?) of the related stuff is in CMake files I guess, but there might be stuff in the C++ code, for example related to plugins.

This doesn't just apply to this repository but also to all the OpenChemistry submodules.

Issues don't get assigned, if you want to contribute just make some changes and open pull requests. There's a build guide at https://two.avogadro.cc/develop/build.html

@ghutchis
Copy link
Member

ghutchis commented Dec 17, 2024

The files to start (e.g., for the thirdparty modules) are

And there's a guide to the relevant CMake bits:
https://cmake.org/cmake/help/latest/command/file.html

@ghutchis ghutchis linked a pull request Dec 19, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants