Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reminder: when we next update ITK, see about disabling its readers #233

Open
mathturtle opened this issue Apr 19, 2018 · 1 comment
Open

Comments

@mathturtle
Copy link
Contributor

We just had an issue with VTK and ITK's HDF5 reader libraries conflicting due to improper mangling. VTK fixed its mangling, but when we next update ITK we should see if we can disable the readers to avoid potential issues like this (we don't use them). This may also be less an issue in future with the external pipeline. Creating this issue as a reminder.

@psavery
Copy link
Contributor

psavery commented Jul 4, 2019

@cryos I did not see this issue unfortunately at the time of my builds. This would probably need to be done before we merge #285, to avoid the HDF5 conflicts. This might also reduce the binary size.

We can update the build instructions with cmake definitions to turn off specific readers, and then re-build them all. The cmake instructions need to be updated in these places:

windows
mac
linux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants