Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Initial Qt6 Build Support #50

Merged
merged 10 commits into from
Dec 2, 2024
Merged

Add Initial Qt6 Build Support #50

merged 10 commits into from
Dec 2, 2024

Conversation

simpsont-oci
Copy link
Contributor

Problem:

  • Build files are not currently set up to build for Qt6
  • A few changes in Qt6 APIs break the build for Qt6

Solution:

  • Expand build coverage to include Qt6
  • Fix build for Qt6 APIs

.github/workflows/build.yml Outdated Show resolved Hide resolved
test/CMakeLists.txt Show resolved Hide resolved
@simpsont-oci
Copy link
Contributor Author

simpsont-oci commented Dec 2, 2024

At some point, we should update the CI/CD workflows to actually verify this continues to build with Qt6 (it does (and runs) on my machine, for what it's worth). We can convert this to draft if you want me to look into that eventually. Or we can open an issue and someone can do it later.

@jrw972 jrw972 merged commit fb968ec into master Dec 2, 2024
12 checks passed
@jrw972 jrw972 mentioned this pull request Dec 2, 2024
@simpsont-oci simpsont-oci deleted the add_qt6_build_support branch December 3, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants