test: queue_perf: clarify error messages

Avoid misleading error messages when queue capabilities don't match given application options. Signed-off-by: Matias Elo <[email protected]> Reviewed-by: Tuomas Taipale <[email protected]>
OpenDataPlane · Oct 9, 2024 · 9d9a067 · 9d9a067
1 parent 40d7ec3
commit 9d9a067
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/test/performance/odp_queue_perf.c b/test/performance/odp_queue_perf.c
@@ -325,6 +325,9 @@ static int create_queues(test_global_t *global)
 			odp_event_free(event[i]);
 	}
 
+	if (ret)
+		ODPH_ERR("Initializing test queues failed.\n");
+
 	return ret;
 }
 
@@ -340,10 +343,8 @@ static int destroy_queues(test_global_t *global)
 	odp_pool_t pool    = global->pool;
 
 	for (i = 0; i < num_queue; i++) {
-		if (queue[i] == ODP_QUEUE_INVALID) {
-			ODPH_ERR("Invalid queue handle (i: %u).\n", i);
+		if (queue[i] == ODP_QUEUE_INVALID)
 			break;
-		}
 
 		for (j = 0; j < num_event; j++) {
 			ev = odp_queue_deq(queue[i]);
@@ -643,10 +644,8 @@ int main(int argc, char **argv)
 
 	global->instance = instance;
 
-	if (create_queues(global)) {
-		ODPH_ERR("Create queues failed.\n");
+	if (create_queues(global))
 		goto destroy;
-	}
 
 	if (start_workers(global)) {
 		ODPH_ERR("Test start failed.\n");