Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing support for datatypes and missing list of supported types #32

Open
jh-RLI opened this issue May 7, 2020 · 4 comments
Open

Missing support for datatypes and missing list of supported types #32

jh-RLI opened this issue May 7, 2020 · 4 comments

Comments

@jh-RLI
Copy link
Contributor

jh-RLI commented May 7, 2020

As part of the development of the oem2orm tool (creation of sqlalchemy tables from oemetadata) and also for the validation of the oemetada JSON strings it is necessary to document the required PostgreSQL data types as requirements.
Can you provide an overview? @Ludee

For the development of tools that use the oedialect it is also important to have an overview of the currently supported datatypes. For example, I noticed that "DOUBLE_PRECISION" is not supported (yet?). The same applies to "float('inf')" as described in this issue #13 .
Which data types are supported by the oedialect? @MGlauer

@christian-rli christian-rli changed the title We need to talk about datatypes Missing support for datatypes and missing list of supported types May 11, 2020
@Ludee
Copy link
Member

Ludee commented May 12, 2020

Here is a list of (postgres) data types I already used in the oedb:

postgres python SQLA
serial
text
varchar
integer
double precision float(15)/numeric
decimal numeric/decimal
hstore
geometry (Point, Line, MultiLine, Polygon, MultiPolygon)

@MGlauer
Copy link
Contributor

MGlauer commented May 12, 2020

This is rather hard to answer - due to the way types are implemented in sqlalchemy - more precisely the infamous love triangle between python types, sqlalchemy classes and postgresql types. There is no comprehensive list of types that are supported.

@jh-RLI
Copy link
Contributor Author

jh-RLI commented May 12, 2020

Okay, then we have to try and error until all required data types are supported? In general, the oedialect supports all data types that sqlalchemy supports?

@MGlauer
Copy link
Contributor

MGlauer commented May 13, 2020

BTW: I worked on a full(-ish) coverage of SQLAlchemy's tests on feature/travis. This includes sqlalchemy.testing.suite.test_types, which should already cover a decent amount of SQLAlchemy's type functionalities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants