Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error and status messages when uploading tables #31

Closed
chrwm opened this issue Nov 24, 2022 · 2 comments · Fixed by #38
Closed

Improve error and status messages when uploading tables #31

chrwm opened this issue Nov 24, 2022 · 2 comments · Fixed by #38
Assignees
@chrwm
Labels
enhancement New feature or request

Comments

@chrwm
Copy link
Member

chrwm commented Nov 24, 2022 •
edited
Loading

Uploading tables with oem2orm, e.g. using the script from the tutorial section, is not user-friendly due a lack of helpful error messages.

  • Inform the user which table is processed. Currently, when the table creation fails and throws a bad/unspecific error message, it is not clear which table is the reason (in case of uploading a bulk of tables)
  • Improve the error messages when violating the postgresql naming conventions for column headers and resources-name. Relates to Column header naming convention is not checked #16 (comment)
@chrwm chrwm added the enhancement New feature or request label Nov 24, 2022
@chrwm chrwm self-assigned this Nov 24, 2022
@jh-RLI
Copy link
Collaborator

jh-RLI commented Nov 28, 2022

FYI @chrwm you want to have a look at the error massages, they are implemented in this function. There are multiple APIErrors raised that return the error string.

chrwm added a commit that referenced this issue Dec 5, 2022
@chrwm
Improve logging of md upload #31
05a3619
chrwm added a commit that referenced this issue Dec 5, 2022
@chrwm
Improve err msg if table doesn't exist #31
125ce57
@chrwm chrwm mentioned this issue Dec 5, 2022
Merged
chrwm added a commit that referenced this issue Dec 13, 2022
@chrwm
Activate logging by default #31
5b171e9 
I don't see why logging shouldn't be the default. Non-developers will appreciate it to see what is going on in the programme, and so will developers in doubt when debugging. If devs want to deactivate logging they can set the parameter to `No`. This appears more functional than inputting this information or writing a custom workaround to avoid user-input with each execution.
chrwm added a commit that referenced this issue Jan 4, 2023
@chrwm
Improve err msg for wrong schema #31
624df67
@chrwm
Copy link
Member Author

chrwm commented Jan 4, 2023

APIError messages have been improved in OpenEnergyPlatform/oeplatform#1139

chrwm added a commit that referenced this issue Jan 4, 2023
@chrwm
Update CHANGELOG.md #31
1772885
chrwm added a commit that referenced this issue Jan 5, 2023
@chrwm
Improve logging #31
72fae2b
@chrwm chrwm closed this as completed in #38 Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrwm chrwm

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve log and error messages OpenEnergyPlatform/oem2orm
2 participants
@jh-RLI @chrwm