Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep track of OEKG modifications (insertions, deletions) #1448

Open
1 task done
adelmemariani opened this issue Nov 1, 2023 · 2 comments · May be fixed by #1689
Open
1 task done

keep track of OEKG modifications (insertions, deletions) #1448

adelmemariani opened this issue Nov 1, 2023 · 2 comments · May be fixed by #1689
Assignees
Labels
enhancement Scenario Bundle Feature of the oeplatform.

Comments

@adelmemariani
Copy link
Contributor

adelmemariani commented Nov 1, 2023

Description of the issue

For OEKG, the ability to see which users have taken which actions is essential.

Ideas of solution

At least we should maintain a history of:

  • Insertions and deletions that users made
  • Time of the actions

We should also be able to roll back the OEKG to a previous state based on:

  • Specific users
  • Time of the actions

Workflow checklist

@adelmemariani adelmemariani self-assigned this Nov 1, 2023
adelmemariani added a commit that referenced this issue Nov 1, 2023
adelmemariani added a commit that referenced this issue Nov 1, 2023
@adelmemariani
Copy link
Contributor Author

adelmemariani commented Nov 2, 2023

I have implemented a history feature that tracks each modification made by a user. Each time a user makes a change in a bundle, while the oekg gets updated, the changed part of the bundle is being logged. It means the previous state of the bundle (before change) along with the new state (after change) of the bundle is being tracked. For each modification, the bundle ID, date and time of the change, and the user who did the change is saved. This will let us filter the changes based on the specific bundle(s), a period of time, or specific user(s). The following is a screenshot of the feature so far:

Screenshot 2023-11-02 at 14 18 33

Do you have suggestions about how to filter and navigate the history? We can also explore options for filtering a specific part of a bundle such as 'study-name' or ...

@OpenEnergyPlatform OpenEnergyPlatform deleted a comment from jh-RLI Nov 2, 2023
@jh-RLI jh-RLI moved this to OEPlatform Todo in factsheets + scenario bundles Nov 3, 2023
@jh-RLI jh-RLI moved this from OEPlatform Todo to In Progress in factsheets + scenario bundles Nov 3, 2023
@jh-RLI jh-RLI added the Scenario Bundle Feature of the oeplatform. label Nov 6, 2023
@stap-m
Copy link
Contributor

stap-m commented Nov 9, 2023

Discussion from oekg-meeting today:

  • changes made by two users at the same time: how to deal with?
    • lock entities that are being edited for other edits
    • implement time out to prevent permanent locks
    • add in-memory-database?
    • lock single entities, or whole bundles, too?
  • have all changes in one place is nice, filtering for bundles, users, time are helpful, too.

@jh-RLI jh-RLI linked a pull request Nov 28, 2024 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Scenario Bundle Feature of the oeplatform.
Projects
Development

Successfully merging a pull request may close this issue.

4 participants