Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PeerReview Process improvements #1798

Open
1 task
Darynarli opened this issue Aug 19, 2024 · 0 comments · May be fixed by #1800
Open
1 task

PeerReview Process improvements #1798

Darynarli opened this issue Aug 19, 2024 · 0 comments · May be fixed by #1800
Assignees
Labels
bug open peer review The open energy platform peer review

Comments

@Darynarli
Copy link
Contributor

Darynarli commented Aug 19, 2024

Description of the issue

During testing of the review process, some errors were found, and ideas were also generated on how to make the review process clearer and easier for users.

Steps to Reproduce

  1. Change the functionality of the "Deny" button
  2. Comments on an accepted field
  3. Peer Review "delete" button
  4. Bugs on Summary Tab
  5. Modifying an accepted field

Ideas of solution

  1. Change the functionality of the "Deny" button:
    • "Deny" will mean deleting a field: after a reviewer suggests deleting a field, the contributor can accept the deletion, and the field will be removed from the metadata.
  2. Comments on an accepted field:
    • Fix the issue with comments on a field that the reviewer/contributor initially rejected/suggested changes to, but later accepted before submission. The comments suggested by the user before the field's acceptance are being displayed.
  3. Peer Review “delete” button:
    • Add a button for deleting Peer Review on the profile page in open review processes, which will completely remove the current review progress and allow another reviewer to start reviewing the metadata anew.
  4. Summary tab:
    • Fix the bug related to the display of the field name (currently not displayed).
    • After the first submit, reviewed fields where I suggested changes or rejected are shown as missing on the contr page. Empty fields on the contributor page are shown twice (with the status empty&missing)
    • Fix the bug that causes the same field to be displayed twice.
  5. Modifying an accepted field:
    • Once a field has been accepted, it cannot be modified, meaning changes or rejections cannot be suggested before submission without refreshing the page.

Context and Environment

  • Version used:
  • Operating system:
  • Environment setup and (python) version:

Workflow checklist

@Darynarli Darynarli added bug open peer review The open energy platform peer review labels Aug 19, 2024
@Darynarli Darynarli linked a pull request Aug 19, 2024 that will close this issue
5 tasks
@Darynarli Darynarli linked a pull request Aug 19, 2024 that will close this issue
5 tasks
Darynarli pushed a commit that referenced this issue Aug 20, 2024
display of empty fields on the page of a participant with two statuses;
 display after submitting reviewed fields (suggest/deny status) on the summary page as missing #1798
Darynarli pushed a commit that referenced this issue Sep 13, 2024
Darynarli pushed a commit that referenced this issue Sep 26, 2024
Darynarli pushed a commit that referenced this issue Oct 16, 2024
Darynarli pushed a commit that referenced this issue Oct 16, 2024
Darynarli pushed a commit that referenced this issue Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug open peer review The open energy platform peer review
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

2 participants