Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResultStore #5

Open
dwhswenson opened this issue Apr 19, 2023 · 1 comment · May be fixed by #10
Open

ResultStore #5

dwhswenson opened this issue Apr 19, 2023 · 1 comment · May be fixed by #10
Assignees

Comments

@dwhswenson
Copy link
Member

dwhswenson commented Apr 19, 2023

This object stores the final results, and is specific to the client application. The retry number is passed to this when storing, and it is up to the client application to ensure that the combination of result object and retry number is ensured a unique location in their storage.

  • is_failure_result(result: ResultObject) -> bool
  • store_result(result: ResultObject, retry: int)
  • load_result(label: str, retry: int): this isn't strictly necessary for Exorcist, but may be useful (and will be needed in the client code anyway)
@dwhswenson dwhswenson self-assigned this Apr 19, 2023
@dwhswenson dwhswenson linked a pull request Apr 19, 2023 that will close this issue
@dwhswenson
Copy link
Member Author

I'm scratching the load_result method here -- it feels application-specific. Client subclasses will likely want to create it, but it feels out of scope for Exorcist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant