Add checks for partial charges #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #219 +/- ##
==========================================
+ Coverage 99.06% 99.12% +0.06%
==========================================
Files 36 36
Lines 1810 1827 +17
==========================================
+ Hits 1793 1811 +18
+ Misses 17 16 -1
☔ View full report in Codecov by Sentry. |
richardjgowers
force-pushed
the
warn-charges
branch
from
8c67f63
to
0966a4c
Compare
richardjgowers
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exact nature of how we warn / error might need some discussion here (including exactly what we tell folks), but it would be good to get this in soon. It's really easy for someone to blindingly pass a component with partial charges and not realise it'll impact the downstream Protocol.