Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gather should support simulation repeats submitted in parallel #987

Open
atravitz opened this issue Oct 28, 2024 · 1 comment
Open

gather should support simulation repeats submitted in parallel #987

atravitz opened this issue Oct 28, 2024 · 1 comment
Labels
cli command-line interface

Comments

@atravitz
Copy link
Contributor

When running quickrun in parallel, the directory structure changes so that results_0, results_1, results_2 , and gather no longer works

We need to decide if gather should become more support his scenario, or if we need to be more strict about user-behavior.

@atravitz atravitz added the cli command-line interface label Oct 28, 2024
@CurtisColwell
Copy link

CurtisColwell commented Oct 29, 2024

Glad this is already here. I am running into this problem now. I changed the protocol_repeats to 1 to run each repeat separately, but it doesn't add to the currently existing .json output. Can I add the new 'protocol_result' and 'unit_results' or will this not work?

A nice solution would be adding the new repeat to the old output file instead of throwing this error:

Error: Invalid value for '-o': File 'results/easy_rbfe_mol1_solvent_mol2_solvent.json' already exists.

@atravitz atravitz added this to the 1.2.0 milestone Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli command-line interface
Projects
None yet
Development

No branches or pull requests

2 participants