Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document functions #5

Open
gedankenstuecke opened this issue Jan 29, 2018 · 8 comments
Open

Document functions #5

gedankenstuecke opened this issue Jan 29, 2018 · 8 comments

Comments

@gedankenstuecke
Copy link
Member

Besides the CLI tools the package contains functions that can be used to interface with the OH API from Python itself. These are not documented so far.

@vineetamotilal
Copy link

@gedankenstuecke this is available right? I can take this up as the project!

@gedankenstuecke
Copy link
Member Author

@vineetamotilal absolutely, please feel free to go ahead with that!

@vineetamotilal
Copy link

@gedankenstuecke Sir, can you mention the functions which need to be documented so that I can go ahead with it.

@gedankenstuecke
Copy link
Member Author

@vineetamotilal Basically all the functions in ohapi/api.py are not having any documentation. It would be great if all of them could be documented, for now maybe in a USAGE.md in the root-folder of the repository. Later on we might want to do a readthedocs page or something else for it, but a single file would be a good start.

Things to document would be the different parameters needed for the function calls and what the functions are doing.

@DartingMelody
Copy link
Contributor

@vineetamotilal, are you still working on this issue? Actually, I want to work on it, so let me know. Thanks :)

@vineetamotilal
Copy link

@DartingMelody please go ahead.

@kritisingh1
Copy link
Contributor

@DartingMelody since there are so many functions in ohapi/api.py, I think it would be better if we work together here too :)
I am taking up the oauth2_auth_url and oauth2_token_exchange for now. Thanks :)

@DartingMelody
Copy link
Contributor

Yeah, sure! It would be great. Feel free to work on them. I will be working on rest of the functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants